Comments (6)
well.. the rule is quite simple - promises should always be returned
here many promises are being created in a loop, but only the last one is getting returned
https://github.com/rpflorence/react-router/blob/7fc55834e9f607f553c96774c99c8cc7785b1c26/lib/router.js#L522
replace with smth like
return when.map(reversedArray(matches), function () {
... make your promise ...
return promise;
});
from react-router.
I'd also suggest using bluebird promise library which logs uncaught errors in browser console.
from react-router.
Or when.
from react-router.
"just do promises right" :P
Anyway, not actually interested in a promise conversation (I was just bugging Michael about them before this commit, talking about how people always mess them up and then app code errors get swallowed, so it was fun for me to come back and say "see ... pain in the neck").
I have two requirements though:
- We don't swallow user's code in our promise usage
- We support a simple callback in transition hooks so people don't have to use promises in application code because half of us have had nothing but bad experiences with them.
I do not want to constantly be having promise conversations with people using this library.
from react-router.
I'll take a look at this today. @rpflorence I agree that the last thing I want is to have endless conversations with people trying to track down swallowed errors, so we'll just fix it and not swallow them. If we can't, we'll remove support for them.
from react-router.
BTW, I'd be happy to discuss support for callbacks in transition hooks in a separate issue. Promises give us guarantees that callbacks don't, and they present a really clean interface for dealing with asynchronous code.
@andreypopp I used es6-promise
because it's just a shim instead of a full-blown library with lots of extra bells and whistles. Using es6-promise
today means we can easily remove it at some point in the future when more runtimes support a native Promise
.
from react-router.
Related Issues (20)
- [Bug]: loader of Route running even if Route / Router is not rendered HOT 2
- [Docs]: Docs for shouldRevalidate make it sound like it is only for opting out
- [Bug]: `useLocation` out of sync with `history.location`, leads to potential renders of unmatched `Route`s
- [Bug]: useLoaderData triggers component re rendering even if the route remains unchanged HOT 1
- [Bug]: Cloudflare Pages - Outlet not working. HOT 33
- [Bug]: No route matches URL in production build HOT 3
- [Bug]: <Outlet/> Component is not working in deployment HOT 1
- [Bug]: `window.location` is not updated after a call to `router.navigate()` HOT 1
- [Bug]: router doesn't work in production build, only shows blank. HOT 1
- [Bug]: `<Navigate>` can be canceled by `navigate("?x")` even if guarded by `if(navigation.state === "idle")` HOT 1
- [Bug]: Using embed in a route with param causes it to render the whole application inside the div. HOT 1
- [Docs]: V6 - Mixing up <Route /> with lists [<Route />, <Route />] within one <Routes /> looks working but isn't mentioned in the docs and covered in unit tests. HOT 1
- [Docs]: update state after action behavior HOT 1
- [Bug]: "Cannot find module './index' or its corresponding type declarations" in react-router-dom/server.d.ts HOT 4
- [Bug]: <Outlet/> not working in build production with Vite. HOT 4
- [Bug]: React Router 6 useLoaderData returning cached data after fresh data is returned by the loader function HOT 5
- [Bug]: Incorrect Module Path in server.d.ts Causes TS2307 Error HOT 1
- [Bug]: Cannot read properties of null (reading b HOT 2
- [Docs]: When should I use `react-router` vs `react-router-dom`? HOT 1
- [Docs]: Invalid hook call when using tutorial code with (Typescript) Create React App HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.