Comments (3)
As a sidenote; the doc (https://reactrouter.com/en/main/routers/create-browser-router#optsunstable_patchroutesonmiss) should not recommend to do something like this:
let router = createBrowserRouter(
[
{
path: "/",
Component: Home,
},
{
id: "dashboard",
path: "/dashboard",
},
{
id: "account",
path: "/account",
},
],
{
async unstable_patchRoutesOnMiss({ path, patch }) {
if (path.startsWith("/dashboard")) {
let children = await import("./dashboard");
patch("dashboard", children);
}
if (path.startsWith("/account")) {
let children = await import("./account");
patch("account", children);
}
},
}
);
Because this way, the exact leaf route "/dashboard" will always show a blank page, even with a "*" route
from react-router.
Yeah I think this is just a setup issue based on the current API design. There is no way to force the function to be called - it is only called when the router otherwise can't match a path - i.e., a "miss" (barring splat route behavior).
By providing the parent route /test
in the critical routes, you're allowing the router to match /test
and it never needs to call patchRoutesOnMiss
when navigating to /test
because it didn't "miss".
The two options to fix this would be:
- Remove the
/test
definition from the critical routes, thus causing a "miss" on/test
and giving you a chance to patch it all in:
let router = createBrowserRouter(
[
{
path: '/',
Component: RootComponent,
},
],
{
async unstable_patchRoutesOnMiss({ path, patch }) {
// Patch the full `/test` tree in here as a new top-level route
if (path.startsWith('/test')) {
patch(null, [
{
id: 'test',
path: '/test',
children: [
{
index: true,
element: <div>Test</div>,
},
{
path: 'another',
element: <div>Another</div>,
},
],
},
]);
}
},
}
);
- Or, you could include the test
index
route in the critical routes so it has everything it needs to match/test
and then only patch in/another
when needed:
let router = createBrowserRouter(
[
{
path: '/',
Component: RootComponent,
},
{
id: 'test',
path: '/test',
children: [{
index: true,
element: <div>Test</div>,
}],
},
],
{
async unstable_patchRoutesOnMiss({ path, patch }) {
// Patch the full `/test` tree in here as a new top-level route
if (path.startsWith('/test/another')) {
patch('test', [{
path: 'another',
element: <div>Another</div>,
}]);
}
},
}
);
from react-router.
I see, thanks 👍
from react-router.
Related Issues (20)
- [Bug]: Uncaught Error: Expected fetch controller: xxx HOT 2
- [Docs]: warning references to polyfill.io, which is found to serve malware HOT 2
- [Docs]: Tutorial missing imports within 'contacts.js'. [ "match-sorter" , "localforage" , "sort-by" ] HOT 1
- [Bug]: history.listen not triggered on hash changes HOT 1
- [Bug]: Update comments recommending to use polyfill.io HOT 3
- [Docs]: Nested Routes are essentially undocumented HOT 5
- [Bug]: unstable_patchRoutesOnMiss is superseded by "*" (404) HOT 3
- [Bug]: Functional updates to `useSearchParams` don't get updated values HOT 2
- Update to isbot@5 HOT 1
- [Bug]: `unstable_patchRoutesOnMiss` remote module error-handling HOT 13
- [Bug]: useMatch does not decode params HOT 4
- [Bug]: Could not resolve './utils' from packages/router/index.ts HOT 2
- [Bug]: Link when used with Outlet is not working. It is routing to error page when clicked. HOT 1
- [Bug]: setSearchParams from useSearchParams remove hash HOT 1
- [Bug]: HashRouter need to wrapped twice HOT 1
- [Docs]: docs show reach/router instead of react/router HOT 2
- [Bug]: "react-router-dom-v5-compat" <CompatRouter> doesn't unsubscribe from history potentially causing tests to memory leak HOT 2
- [Bug]: child loader redirect overrides parent loader error HOT 7
- [Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.