allow the markdown to be specified as plain node content? about react-markdown HOT 6 CLOSED

Sure. As long as it's backwards compatible, I'll accept a PR.

from react-markdown.

Since I have not received a PR for this, I assume no one wants it enough to actually put in the effort.
For anyone looking to implement it, simply passing on children to the underlying library isn't quite good enough, as someone might pass in a react element inside of the children. You'd at least have to flatten the tree of children and extract the text nodes. Or throw if non-text nodes are encountered.

from react-markdown.

here here. When I came across the library I was instantly thinking "why isn't it using children as the markdown body?"
I'd treat children as to be only one, a string, and not accept react elements inside it.

from react-markdown.

Happy to accept a pull request.

from react-markdown.

I am just thinking how the jsx compiler would treat this:

<Markdown>What a **bold** move.</Markdown>

Will it have converted the text into chunks of <span>? Guess I have to try it to find out. Let the forking begin :)

from react-markdown.

@rexxars Hmmm tried to run the tests before doing any dev to see if they are all green and got:

$ npm t

> [email protected] test C:\dev\projects\react-markdown
> mocha --reporter spec



  ReactMarkdown
    1) "before all" hook


  0 passing (3s)
  1 failing

  1) ReactMarkdown "before all" hook:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at Object.done (node_modules\mocha-jsdom\index.js:70:7)
      at process.nextTick (node_modules\jsdom\lib\jsdom.js:325:18)
      at _combinedTickCallback (internal/process/next_tick.js:67:7)
      at process._tickCallback (internal/process/next_tick.js:98:9)

from react-markdown.