Code Monkey home page Code Monkey logo

Comments (7)

vio avatar vio commented on July 19, 2024 1

Thanks @gjsduarte! The CLI is already allowing overrides via arguments, i think will make a lot of sense to allow it for the webpack plugin as well.

Did you encounter problems with any of the env-ci variables?

from agent.

gjsduarte avatar gjsduarte commented on July 19, 2024 1

We're collecting the Github PR number using https://github.com/useparcel/vercel-is-pull-request

But if you're already collecting the PR from the GitHub api already, then this might be redundant.
I'll give it a test with the latest version when you release a bump to env-ci to if it's still needed

from agent.

vio avatar vio commented on July 19, 2024 1

Thanks for sharing @gjsduarte!

If you are using it with @relative-ci/agent to send the pr number, is not necessary anymore. RelativeCI picks up the corresponding pr number for vercel builds using octokit.js listPullRequestsAssociatedWithCommit.

from agent.

gjsduarte avatar gjsduarte commented on July 19, 2024

Yes, We're running builds out of Vercel, which doesn't expose a PR number environment variable.

We do collect the PR number using another method and would like to forward this to relative-ci to enable PR status comments

from agent.

vio avatar vio commented on July 19, 2024

We do collect the PR number using another method and would like to forward this to relative-ci to enable PR status comments

Can you share what method you are using? Maybe we can add the same method upstream?

We're running builds out of Vercel, which doesn't expose a PR number environment variable.

For specific CI providers, RelativeCI is using the GitHub api to get the corresponding PR based on sha when the agent is not providing one. I added vercel to the list as well ;)

from agent.

github-actions avatar github-actions commented on July 19, 2024

This issue is stale because it has been open for 30 days with no activity.

from agent.

github-actions avatar github-actions commented on July 19, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

from agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.