Option to add aria-label about rehype-external-links HOT 4 CLOSED

Hi!

I like the alternative you propose better than adding more and more properties on the options object itself.

It’s slightly weird that target and rel are on the root options object, if there’s also a linkProperties or so. And which should get precedence if linkProperties.rel is set?

And what name to use? Maybe properties is fine?

One thing to think about: those properties need to be deep cloned, because rel or className could be arrays. And there are other values allowed.

Would you be interested in working on a PR?
Would be something like https://github.com/rehypejs/rehype-autolink-headings/blob/a37d231c4c0c29c6880d8e1b6842dfbd771027dc/lib/index.js#L21-L24, https://github.com/rehypejs/rehype-autolink-headings/blob/a37d231c4c0c29c6880d8e1b6842dfbd771027dc/lib/index.js#L108. With a default of {} I think. And then rel and target are preferred over properties.rel/properties.target?

from rehype-external-links.

Hi! This was marked as ready to be worked on! Note that while this is ready to be worked on, nothing is said about priority: it may take a while for this to be solved.

Is this something you can and want to work on?

Team: please use the area/* (to describe the scope of the change), platform/* (if this is related to a specific one), and semver/* and type/* labels to annotate this. If this is first-timers friendly, add good first issue and if this could use help, add help wanted.

from rehype-external-links.

I don‘t think this is a good use of ARIA btw. Not only screen readers need to know where your link goes. Everyone does.

from rehype-external-links.

There's still no consensus on this, but I think I got the idea from these two sources:

https://it.wisc.edu/learn/make-it-accessible/develop-accessible-websites/when-to-open-links-in-a-new-tab/
https://www.digitala11y.com/external-links-in-or-out/

My bad for using a bad example -- it should really include the destination as recommended in the articles.

from rehype-external-links.