Code Monkey home page Code Monkey logo

Comments (2)

Turnerj avatar Turnerj commented on June 2, 2024

It is technically behaving as intended though the intended behaviour isn't fantastic. Basically the ValueJsonConverter performs a "right-to-left" type check for any objects it tries to deserialize. The types for itemListElement are ListItem, Text or Thing from "left-to-right". This ordering is just from how we get the data in the schema.json files we process.

Because everything implements IThing, it succeeds with deserializing and doesn't try other types. What we could do is alter the logic to try a different algorithm for best fit - something that demotes Thing to the last possible choice.

It might seem somewhat obvious in this example that we could just switch from "right-to-left" to "left-to-right" however we'd need to confirm we aren't just creating the same problem for other schema properties.

from schema.net.

dermotblairca avatar dermotblairca commented on June 2, 2024

Thanks for looking into it @Turnerj That makes sense.
A workaround I used was just to check if the current item "is" an IListItem, if HasValue3 returns true.

if (itemList.ItemListElement.HasValue3)
{
	foreach (var listItem in itemList.ItemListElement.Value3)
	{
		if (listItem is IListItem)
		{
			// do something with list item
		}
	}
}

from schema.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.