Code Monkey home page Code Monkey logo

Comments (5)

regorxxx avatar regorxxx commented on May 31, 2024 1

Ok, should work now.

from search-by-distance-smp.

username116 avatar username116 commented on May 31, 2024 1

Good to know it's a bug.
I tried the latest version. With the same reference track (the one that is Psychedelic Rock) the few tracks with empty "graph" tags have disappeared. The result is better: this time there are only identical genres (in those "graph" tags) in the playlist. So that's great.

With a reference track with empty "graph" tags, the result is the same: the 2 playlists are identical.
I've seen the warning. I understand the logic, but it can be a bit surprising to still have these "0 Graph" scores in the console, when it's a Weight method, and the "graph" tags can be empty on both sides. That's okay because I got your explanation. Maybe add in the warning that "all Graph scores will be 0"?

Thank you for this improvement and for the explanation.

from search-by-distance-smp.

regorxxx avatar regorxxx commented on May 31, 2024

That's a bug, the distance for not found genres (or in this case no genre) is Infinity.

At some point I deleted the check for no genres, should be fixed now (can not test it).

  • A reference track with no genre will throw a warning and report any other track as zero distance (uses WEIGHT as fallback and just compares scores). Why? Because it's a more logic expectation than having zero results using GRAPH.
  • For reference track with genre, compared tracks with no genre will have an Infinity distance (and thus never used at output). Again the most logical expectation.

Let me know

EDIT: found other things in the process, wait some time.

from search-by-distance-smp.

regorxxx avatar regorxxx commented on May 31, 2024

Yep, will add something like that and improve it.

from search-by-distance-smp.

username116 avatar username116 commented on May 31, 2024

I saw the new messages in the console. It's good, it shows well when the tags are empty.

from search-by-distance-smp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.