Comments (5)
Ok, should work now.
from search-by-distance-smp.
Good to know it's a bug.
I tried the latest version. With the same reference track (the one that is Psychedelic Rock) the few tracks with empty "graph" tags have disappeared. The result is better: this time there are only identical genres (in those "graph" tags) in the playlist. So that's great.
With a reference track with empty "graph" tags, the result is the same: the 2 playlists are identical.
I've seen the warning. I understand the logic, but it can be a bit surprising to still have these "0 Graph" scores in the console, when it's a Weight method, and the "graph" tags can be empty on both sides. That's okay because I got your explanation. Maybe add in the warning that "all Graph scores will be 0"?
Thank you for this improvement and for the explanation.
from search-by-distance-smp.
That's a bug, the distance for not found genres (or in this case no genre) is Infinity.
At some point I deleted the check for no genres, should be fixed now (can not test it).
- A reference track with no genre will throw a warning and report any other track as zero distance (uses WEIGHT as fallback and just compares scores). Why? Because it's a more logic expectation than having zero results using GRAPH.
- For reference track with genre, compared tracks with no genre will have an Infinity distance (and thus never used at output). Again the most logical expectation.
Let me know
EDIT: found other things in the process, wait some time.
from search-by-distance-smp.
Yep, will add something like that and improve it.
from search-by-distance-smp.
I saw the new messages in the console. It's good, it shows well when the tags are empty.
from search-by-distance-smp.
Related Issues (20)
- No results with remapped tag HOT 59
- [FEATURE] Unlimited custom tag slots HOT 1
- [BUG] Tag cache with empty values HOT 1
- [TODO] Cultural filter
- [TODO] Cultural distance HOT 2
- [BUG] Recipe non valid: Similar genres (D) HOT 2
- Primary Origin keys order HOT 3
- [FEATURE] Custom graph for custom tag HOT 8
- [BUG] missing property (baseScore) HOT 1
- [BUG] Readme not found HOT 1
- [BUG] tagNameTF.some is not a function HOT 3
- [BUG] Small mistakes in the Readme files HOT 1
- [BUG] Custom tag names displayed incorrectly in the menu HOT 2
- Different results with custom tag slot HOT 7
- [BUG] HOT 3
- [FEATURE] Essentia
- [BUG] missing range property HOT 1
- [BUG] Recipe error HOT 2
- [BUG] remove_duplicates.js HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from search-by-distance-smp.