Code Monkey home page Code Monkey logo

Comments (5)

ivannador avatar ivannador commented on August 23, 2024 1

Wow that was fast, thanks. :)

Personally I think it would be best to provide an indicateCharacteristic() method (with the same arguments as its notify counterpart). It could then set the ENABLE_INDICATION_VALUE in the descriptor internally. No other descriptor value setting is needed I think.
AFAIK on iOS it wouldn't matter as it handles it automatically. No clue about macOS though but I imagine it works the same.

from blue-falcon.

Reedyuk avatar Reedyuk commented on August 23, 2024 1

I have merged and published as 0.6.5, this should appear in maven central within the next few hours.

from blue-falcon.

Reedyuk avatar Reedyuk commented on August 23, 2024

So you would want to send an enum something like:
public static final byte[] ENABLE_NOTIFICATION_VALUE
public static final byte[] ENABLE_INDICATION_VALUE
public static final byte[] DISABLE_NOTIFICATION_VALUE

Would you also want to be able to set the descriptor value too?

Just trying to think how i can make this as generic as possible to support Android, iOS, MacOS.

from blue-falcon.

Reedyuk avatar Reedyuk commented on August 23, 2024

Yep makes sense, let me see if i can squeeze out a change over the weekend, otherwise, happy for you to fork and put a pr in.

from blue-falcon.

ivannador avatar ivannador commented on August 23, 2024

Just published a PR. I also added the possibility to set both notification and indication. That makes it more in line with iOS functionality.

from blue-falcon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.