Comments (5)
An addendum: this will be a breaking change, so we're talking a major version here.
from socrates.
Alternatively, we could deprecate the method returning the Carbon instance, and then later remove it altogether...
Thoughts @JoaoFSCruz ?
from socrates.
Currently we are using Carbon when manipulating dates in the extractors and to define the date of birth in the Citizen model. If we just deprecate the Citizen's method to return a DateTime instance instead of a Carbon instance we are not making that of a difference.
Maybe really push for the bigger change and totally lose Carbon. π€·ββοΈ
from socrates.
Maybe really push for the bigger change and totally lose Carbon. man_shrugging
It would however mean that we could have a smoother transition to getting rid of Carbon without introducing a breaking change out of the blue. Something like v1.3.0 having a new getDateOfBirthNative()
method alongside the old Carbon
returning one, and then on v2.0, the original getDateOfBirth()
would be rewritten to return a DateTime
.
from socrates.
I may have misunderstood π
When upgrading to a later version we can get rid of Carbon. But until then we can implement another method returning a DateTime instance for a smooth transition.
That sounds totally fine π
from socrates.
Related Issues (20)
- Fix & standardize Validation tests across all countries HOT 1
- French special month codes HOT 1
- France Metropolitan Lyon Region Validation HOT 7
- [v1.3.0] Implement Mexico π²π½
- Luxembourg ID validation HOT 4
- [v1.3.0] Implement Argentina ID π¦π· (CUIL-CUIT) validator HOT 1
- [v1.3.0] Implement Chile ID π¨π± (RUT) validator HOT 2
- [v1.3.0] Incorrect ID validation for Belgium. HOT 5
- [v1.3.0] Remove Laravel framework detection
- [v1.3.0] Create country constants
- [v1.3.0] Make Gender.php and Countries.php abstract HOT 1
- Implement South Africa πΏπ¦ HOT 2
- [v1.3.0] Implement Uruguay ID πΊπΎ (CI) validator
- [v1.3.0] Implement Peru ID π΅πͺ (CUI) validator
- [v1.3.0] Improve contribution guidelines
- [v1.3.0] Improve PHPDoc on InvalidLengthException
- [v1.3.0] Implement Ecuador ID πͺπ¨ (CI) validator
- [v1.3.0] Deprecate Carbon instance returning methods
- Implement Luxembourg π±πΊ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from socrates.