Comments (4)
If there is anything i could do to solve this issue let me know.
I would even try and solve this myself, however, i'd rather discuss the possible solution with you first.
from swagger-brake.
@pkunze thanks for reporting. I think the only thing we're missing from the code is a check to see whether the attribute being removed is marked as deprecated or not. And if it is, just simply skip that attribute. The code should be here: io.redskap.swagger.brake.core.rule.request.RequestTypeAttributeRemovedRule
and respectively there's one for response attributes too: io.redskap.swagger.brake.core.rule.response.ResponseTypeAttributeRemovedRule
The logic should be similar to what we have for APIs as well in: io.redskap.swagger.brake.core.rule.path.PathDeletedRule
if (!newApi.getPath(p).isPresent()) {
if (!p.isDeprecated() || !checkerOptions.isDeprecatedApiDeletionAllowed()) {
log.debug("Path {} is not included in the new API", p);
breakingChanges.add(new PathDeletedBreakingChange(p.getPath(), p.getMethod()));
} else {
log.debug("Path {} is not included in the new API however it was marked as deprecated", p);
}
} else {
log.debug("Path {} is present in the new API as well", p);
}
from swagger-brake.
Allright, I'll ask a friend of mine to give me a Java Development Jump-Start and give it a shot. :)
from swagger-brake.
Fixed in #98
from swagger-brake.
Related Issues (20)
- Include version number into report and filename HOT 5
- UnsupportedClassVersionError: SwaggerBrakeMain has been compiled by a more recent version HOT 3
- Add support for packaging type .yaml HOT 3
- Exception when comparing swagger files HOT 2
- Recursive schema throws NPE HOT 1
- swagger-brake not reporting violation in breaking changes | MIN/MAX validation | POST object mandatory field validation HOT 6
- Support for String minLength/maxLength constraints
- Support for Array minItems/maxItems/uniqueItems constraints
- Required fields in nested definitions are being reported as breaking when they are not HOT 3
- Add support for war files
- Schema class attributeRequiredMap.get(attrToSearchFor); returning null HOT 5
- java.lang.OutOfMemoryError upon first try HOT 16
- Dependency Dashboard
- JDK upgrade
- JUnit 4 migration to JUnit 5
- Upgrade OpenAPI parser
- Switch Docker image build to Google Jib
- Report all changes optionally HOT 1
- Swagger brake cli jar in maven repository HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swagger-brake.