Code Monkey home page Code Monkey logo

Comments (8)

joyang1 avatar joyang1 commented on June 2, 2024 2

I will fix this issue.
And then provide a new release version.
Thanks.

from jredisbloom.

Nitesh7 avatar Nitesh7 commented on June 2, 2024 1

@joyang1 Delete not working for me still, I wrote test case for checking delete and it failed.

@test

  • public void testDelete() {

  •    cl.createFilter("myBloomDelete", 100, 0.001);
    
  •    assertTrue(cl.add("myBloomDelete", "val1"));
    
  •    assertTrue(cl.exists("myBloomDelete", "val1"));
    
  •    cl.delete("myBloomDelete");
    
  •    assertFalse(cl.exists("myBloomDelete", "val1"));
    

    }

    }
    This is the output I get

junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertFalse(Assert.java:39)
at junit.framework.Assert.assertFalse(Assert.java:47)
at junit.framework.TestCase.assertFalse(TestCase.java:219)
at io.rebloom.client.ClientTest.testDelete(ClientTest.java:146)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at

from jredisbloom.

joyang1 avatar joyang1 commented on June 2, 2024

hi, I have test delete method of Client.
It's OK.
you can use createFilter to test that you whether delete successfully.
If you did not delete, this will create failed, then will create successfully.

from jredisbloom.

DaC1989 avatar DaC1989 commented on June 2, 2024

I have the same problem, any ideas?

from jredisbloom.

DaC1989 avatar DaC1989 commented on June 2, 2024

maybe there is something wrong with the method "client.delete", I changed it like this:

/**
   * Remove the filter
   * @param name
   */
  public void delete(String name) {
//    _conn().getClient().del(name);
    try (Jedis conn = _conn()) {
      conn.del(name);
    }
  }

and it worked, perhaps I will see it why later

from jredisbloom.

Nitesh7 avatar Nitesh7 commented on June 2, 2024

Fixed the issue here: https://github.com/Nitesh7/JReBloom?organization=Nitesh7&organization=Nitesh7

from jredisbloom.

joyang1 avatar joyang1 commented on June 2, 2024

this issue is already solved. You can use 1.2.0 version.

from jredisbloom.

Nitesh7 avatar Nitesh7 commented on June 2, 2024

this issue is already solved. You can use 1.2.0 version.
Thanks @joyang1

from jredisbloom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.