pytest run fails on `Defining 'pytest_plugins' in a non-top-level conftest is no longer supported` about ocs-ci HOT 7 CLOSED

Is this blocking only deployment?
I just managed to execute tier 1 without issues

from ocs-ci.

@RazTamir it happens during collecting phase, it will affect any tests. The problem is visible since merge of #104, which was merged just few hours ago.

Edit: as Petr points out below, if you specify at least tests directory, pytest will collect test cases only there and you won't hit this.

from ocs-ci.

@mbukatov I see you didn't defined the folder of tests in you command so pytest is taking the ./ as default I think so than it's trying to collect everything under the path. So I think that user have to define the ./tests folder when running pytest to provide the path of tests where we have our tests.

So if you will run
py.test -m deployment --cluster-name mbukatov-ocsqe ./tests do you still see the issue?

from ocs-ci.

@mbukatov I see you didn't defined the folder of tests in you command so pytest is taking the ./ as default I think so than it's trying to collect everything under the path. So I think that user have to define the ./tests folder when running pytest to provide the path of tests where we have our tests.

You are right that pytest is trying to collect everything in the current directory. That said, making boundaries between unittests and actual tests explicit is a good idea, and I just forgot to make sure it's enforced.

from ocs-ci.

@mbukatov what do you propose to fix this? I see that boundaries are already defined in different folders which we documented should be used to run with. I think that it's normal from user to have specified test directory/path to be defined.

from ocs-ci.

@mbukatov what do you propose to fix this?

#109

I see that boundaries are already defined in different folders which we documented should be used to run with. I think that it's normal from user to have specified test directory/path to be defined.

Correct. It will just make pytest more resilient to such errors, esp. for deployment.

from ocs-ci.

Fixed by #109

from ocs-ci.