Code Monkey home page Code Monkey logo

Comments (5)

mikeb01 avatar mikeb01 commented on September 25, 2024 1

This should be fixed now. There is a test to cover this as well.

from aeron.

reissGRVS avatar reissGRVS commented on September 25, 2024

I think https://github.com/real-logic/aeron/blob/master/aeron-driver/src/main/c/media/aeron_send_channel_endpoint.c#L301-L308 needs fixed as well, either it shouldn't loop, or it should but only until it successfully sets the timestamp?

from aeron.

mikeb01 avatar mikeb01 commented on September 25, 2024

This isn't broken as it stands. You can have multiple entries in those vectors consisting of non-fragmented packets. It could be made a little more efficient if you wanted to assume that two packets in the same vector would have the same timestamps. Given that the iov in this case is generally fairly small (default is two), then optimising for an early exit from the loop is probably not worth the complexity.

from aeron.

reissGRVS avatar reissGRVS commented on September 25, 2024

It’s currently accessing index 0 on each loop iteration, it’s not using i at all

from aeron.

mikeb01 avatar mikeb01 commented on September 25, 2024

I'd missed that part, it is fixed now

from aeron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.