Redefinition of module ReactCommon when upgrading to 0.74 about react-native-releases HOT 8 CLOSED

Hi There, I had a look at this issue. It looks like you are using Firebase in the app.

When using Firebase, you have to follow the Firebase setup steps.

Once that's done, you'll find another problem in RNCheckNotificationPermission library. This import is broken, there is no rNCheckNotificationPermission file in the library. That line should be replaced by the following.

- #import "rNCheckNotificationPermission-Swift.h"
+ #import "RNCheckNotificationPermission/RNCheckNotificationPermission-Swift.h"

with these two changes, the build will fail because the GOOGLE_APP_ID setting is missing. This should help.

from react-native-releases.

Hi. I fixed this issue through the process of adding and deleting from the code below.

$RNFirebaseAsStaticFramework = false // delete
$RNFirebaseAnalyticsWithoutAdIdSupport = true // delete

use_modular_headers! // delete

target 'YOUR_TARGET' do
  config = use_native_modules!

  use_frameworks! :linkage => :static # add
  $RNFirebaseAsStaticFramework = true # add

  use_react_native!(
    :path => config[:reactNativePath],
    :app_path => "#{Pod::Config.instance.installation_root}/.."
    )
end

Additionally, I use RNFirebase and upgrade react-native version from 0.71.19 to 0.74.1

from react-native-releases.

Same thing happening here.

from react-native-releases.

same thing with me

from react-native-releases.

Hi there! Sorry for the long delay, but with the React Conf coming up I hadn't time to look into this.
I'm cloning the reproducer now to see what's going on! Thanks @justbaum30 for providing it!

from react-native-releases.

I'm using Crashlytics and experiencing the same issue with Xcode Version 15.4. Initially, I was using version 0.72.5, and iOS builds were successful. However, after upgrading to version 0.74.2, this error began to occur. I tried installing version 0.73.8, and it does work there.

In my project, the pods are being added like this:

linkage = ENV['USE_FRAMEWORKS']
if linkage != nil
  Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
  use_frameworks! :linkage => linkage.to_sym
end

I tried changing the configuration to:

use_frameworks! :linkage => :static

but this generated other sorts of errors.

I have attempted to clean the build folder and erase the derived data, but these steps did not resolve the issue with version 0.74.2. For now, I will use version 0.73.8 until a fix for this error can be found.

Additionally, I am not using RNFirebase.

Any assistance would be greatly appreciated.

from react-native-releases.

@eunbae0 can you please paste POD file, AppDelegate.mm, After I added Firebase it's failed tried your above suggestion but still the same issue.

from react-native-releases.

@sireeshp This is my entire Podfile & AppDelegate.mm

require Pod::Executable.execute_command('node', ['-p',
  'require.resolve(
    "react-native/scripts/react_native_pods.rb",
    {paths: [process.argv[1]]},
  )', __dir__]).strip

platform :ios, min_ios_version_supported
prepare_react_native_project!

target 'YOUR_TARGET' do
  config = use_native_modules!
  use_frameworks! :linkage => :static
  $RNFirebaseAsStaticFramework = true

  use_react_native!(
    :path => config[:reactNativePath],
    :app_path => "#{Pod::Config.instance.installation_root}/.."
    )
end

post_install do |installer|
  react_native_post_install(
    installer,
    :mac_catalyst_enabled => false,
  )
  installer.pods_project.targets.each do |target|
    if target.name == "React-Core.common-AccessibilityResources"
      target.remove_from_project
    end
    target.build_configurations.each do |config|
      config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
      config.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET'
    end
  end
end

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>
#import <CodePush/CodePush.h>
#import <Firebase.h>
#import "RNBootSplash.h"
#import "SDImageCodersManager.h"
#import <SDWebImageWebPCoder/SDImageWebPCoder.h>
#import <React/RCTLinkingManager.h>

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  self.moduleName = @"uoslife";
  self.initialProps = @{};

  [FIRApp configure];

  bool didFinish = [super application:application didFinishLaunchingWithOptions:launchOptions];

  [SDImageCodersManager.sharedManager addCoder:SDImageWebPCoder.sharedCoder];

  return didFinish;
}

- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
{
  return [self bundleURL];
}
 
- (NSURL *)bundleURL
{
#if DEBUG
  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
#else
  return [CodePush bundleURL];
#endif
}

- (void)customizeRootView:(RCTRootView *)rootView {
  [RNBootSplash initWithStoryboard:@"BootSplash" rootView:rootView]; // ⬅️ initialize the splash screen
}

- (BOOL)concurrentRootEnabled
{
  return true;
}

- (BOOL)application:(UIApplication *)application
   openURL:(NSURL *)url
   options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
{
  return [RCTLinkingManager application:application openURL:url options:options];
}

@end

I hope this will help you. And react-native-upgrade-helper might help you.

from react-native-releases.