Not able to import fontawesome with standard loading configuration about react-webpack-babel HOT 7 CLOSED

The problem here is the config being ignored for node_modules

You may have to exclude it for font-awesome only here.

from react-webpack-babel.

This might have been my fault cause I've recently submitted a PR for this 😆
I assumed all the fonts to be installed locally

This is a starter and for sure it can't satisfy everybody's needs, it should be modified for each project, but still probably most fonts are installed via npm so should we change this default? @alicoding what do you think?

from react-webpack-babel.

@LeonardoGentile hehe no worries I guess we could just remove that exclusion or we could just document this somehow?

from react-webpack-babel.

Being a starter, it should not 'assume' things in my view.

from react-webpack-babel.

@alicoding you just mentioned someone else 😆
@emhamzahazeen without assumption the starter would not work for the majority of people, it would just not work for anybody IMO.

I've checked and the font loaders were excluding the node_packages even before my PR, but honestly I don't know what's the percentage of people loading font from npm vs locals, so fixing it for some people would break things for others, do you see my point @emhamzahazeen ?

from react-webpack-babel.

Oopsy! So many people in my list and I just assumed the first one :P

from react-webpack-babel.

@LeonardoGentile Maybe have two versions, one commented accordingly with instructions, and current one being the active one?

from react-webpack-babel.