Code Monkey home page Code Monkey logo

Comments (2)

alongd avatar alongd commented on June 8, 2024

Thanks! I agree this is necessary.
@dranasinghe once suggested we make it completely modular, so users can specify the exact job types they'd like and the order they'd like to have it executed in.

We already have the job_types argument, I think we should make its functionality such that the following specs will do what this issue requests:

job_types =  {
    'conformers': False,
    'opt': False,
    'fine_grid': True,
    'freq': True,
    'rotors': True,
    'sp': True
    'orbitals': False,
},

And if we'd like to go really fancy, we could also expand specific_job_type to encode the above dict, see something similar here.

I think the only required change to achieve the original goal requires only slight modifications in scheduler.run_opt_job
Perhaps do something like:

fine = self.job_types['fine'] and not self.job_types['opt']

and add fine=fine to the self.run_job() call

from arc.

amarkpayne avatar amarkpayne commented on June 8, 2024

Sorry I just missed this post before I opened the PR. I can implement something like what you are describing here, where fine=True, opt=False only runs one optimization at a fine level and fine=True, opt=True does the default behavior.

As for the future going forward, I agree with you and @dranasinghe that it would be a good idea to make it completely modular so that the user can decide which jobs to run in what order. Perhaps there is a way to balance this so that common or recommended approaches are called by default (or easily) if the user doesn't specify an order explicitly.

from arc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.