Move @emotion/core to Peer Dependencies about react-pure-loaders HOT 7 CLOSED

Should be a breaking change

from react-pure-loaders.

@Larissagilliane Thank you for your contributions to the project. I really appreciate all the work you put into your three PR’s. If you can get those issues resolved I will get them merged in as soon as possible.

from react-pure-loaders.

i already did the change and don't see any trouble or broken feature.

from react-pure-loaders.

@Larissagilliane I will be digging into this today.

from react-pure-loaders.

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from react-pure-loaders.

So basically, out of the box it's not gonna work. You have to find this issue, learn about peerDependencies, then install that @emotion/core manually. Is my understanding correct?
I just wonder - what is so special about that @emotion/core thing that we have to deal with all this? Couldn't it just be added as a regular dependency?

from react-pure-loaders.

@OnkelTem We moved it as a peerDependencie to prevent version conflicts of emotion, this allows the end user to maintain and use whatever version of emotion they would like.

The install instructions clearly show you need to install not only react-pure-loaders but also @emotion/core

from react-pure-loaders.