Code Monkey home page Code Monkey logo

Comments (2)

aeneasr avatar aeneasr commented on May 18, 2024

@inyono

I did a lot of profiling and debugging. One of the main reason for slowness is that every time an event is dispatched, ALL rows and cells are being rendered. This is because this.props !== props is always true. I tried some things and my conclusion is, that functions are causing the equal (and deep-equal and shallowEqual) checks to fail.

This prohibits rendering but also prohibits propagation of children, which prohibits updates in total (i think):

import deepEqual from 'deep-equal'
var diff = require('deep-diff').diff

export const shouldPureComponentUpdate = function (nextProps) {
  // if (Math.random() > 0.98 && nextProps.cells) {
  //   console.log(nextProps, this.props, 'deepEqual', deepEqual(nextProps, this.props))
  // }

  const nextKeys = Object.keys(nextProps)
  const lastKeys = Object.keys(this.props)
  const next = nextKeys.filter((k) => typeof nextProps[k] !== 'function')
  const last = lastKeys.filter((k) => typeof nextProps[k] !== 'function')

  if (!deepEqual(next, last)) {
    return false
  }

  // eslint-disable-next-line no-invalid-this
  return next.filter((k) => nextProps[k] !== this.props[k]).length > 0
}

from react-page.

aeneasr avatar aeneasr commented on May 18, 2024
import deepEqual from 'deep-equal'

export const shouldPureComponentUpdate = function (nextProps) {
  // eslint-disable-next-line no-invalid-this
  const lastKeys = Object.keys(this.props)
  const nextKeys = Object.keys(nextProps)
  if (!deepEqual(lastKeys, nextKeys)) {
    return false
  }

  const next = nextKeys.filter((k) => typeof nextProps[k] !== 'function')
  // eslint-disable-next-line no-invalid-this
  const changed = next.filter((k) => !deepEqual(nextProps[k], this.props[k])).length

  return changed > 0
}

causes some updates to be skipped and some to be propagated. it's however quite buggy and doesn't really increase the speed

from react-page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.