Code Monkey home page Code Monkey logo

Comments (2)

Wiingaard avatar Wiingaard commented on September 25, 2024 1

Thanks for the quick response and solution 🏆

I applied the changes from #2325 as a patch, which did fix the issue for me.

I had one other issue in the snippet I originally pasted. It complained that Promise.resolve is not a constructor so I changed the implementation of getDiagnostics and runAutomaticFix a bit:

module.exports = {
    healthChecks: [
        {
            label: 'Custom Category',
            healthchecks: [
                {
                    label: 'Custom Health Check',
                    description: 'This is a custom health check',
                    visible: true,
                    isRequired: true,
                    getDiagnostics: async () => {
                        return {
                            needsToBeFixed: false,
                        };
                    },
                    runAutomaticFix: async () => {
                        return;
                    },
                },
            ],
        },
    ],
};

Also, thanks for fixing the documentation 👍

from cli.

TMisiukiewicz avatar TMisiukiewicz commented on September 25, 2024

Hi @Wiingaard, thanks for reporting an issue! It is fact that user-defined health checks were not passed to the config, making it impossible to become visible by doctor command. Opened a #2325 to fix it.

Additionally, your example config has a typo:

module.exports = {
    healthChecks: [
        {
            label: 'Custom category',
-            healthChecks: [
+            healthchecks: [
                {
                    label: 'Custom Health Check',
                    description: 'This is a custom health check',
                    visible: true,
                    isRequired: true,
                    getDiagnostics: async () => {
                        return new Promise.resolve({
                            needsToBeFixed: true
                        })
                    },
                    runAutomaticFix: async () => {
                        return new Promise.resolve({})
                    }
                }
            ]
        }
    ]
};

Also, opened a #2326 to fix the syntax error in docs example 👍

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.