defaultValue props bug about time-picker HOT 12 OPEN

You should use value to control the component.

https://facebook.github.io/react/docs/forms.html#controlled-components

from time-picker.

That also doesn't work

class CustomTimePickerModal extends React.Component {

    constructor(props){
      super(props);
      this.state = { value: this.props.defaultValue };
    }
  onChange = value => {
      this.setState({ value: value });
      this.props.onChange(value)
  }


  render() {
    return (
      <div className={styles.timepicker}>
        <TimePicker  showSecond={false} onChange={this.onChange}  clearText={'Close the Picker'} value={this.state.value} placeholder={`${moment().format('hh:mm')}` || `${moment().format('hh:mm')}`} />
      </div>
    );
  }
}

from time-picker.

The value should be a moment instance but moment().format('xx') is not one.

from time-picker.

That's how I am passing the value to the custom component defaultValue={moment(task.realizedStartTime)}

from time-picker.

That's the moment object which is created

from time-picker.

That formated value was passed to placeholder prop not to value
placeholder={${moment().format('hh:mm')}||${moment().format('hh:mm')}}

from time-picker.

Could you provide a reproducible demo by forking this: https://codesandbox.io/s/mrq288569 ?

from time-picker.

Here is it https://codesandbox.io/s/zqww68629p

As you can check it doesn't return the correct value in the console.

from time-picker.

I think the issue was probably related to call back as I am getting the correct value in the component call back who is using the date picker.

from time-picker.

@Mujaddadi I am facing same problem. did you fix this one?

from time-picker.

@Rainpia I started using some other date picker. As you can see this issue is almost 2 years old and still open, I don't have hope that the developer has time to fix it.

from time-picker.

For me using moment(offStartTime, 'HH:mm') instead of moment(offStartTime).format('HH:mm') did the trick

from time-picker.