ESLint rule to prevent `connectObservable` and `connectFactoryObservable` being used inside components about react-rxjs HOT 6 CLOSED

Sure, I'll give it a go this afternoon!

from react-rxjs.

It looks awesome, my only reservation is with the name of the rule... I think that instead of connect-in-components it should be named no-connect-in-components. I think that name is a bit more consistent with other standard eslint-rules, e.g. no-await-in-loop, no-console, no-import-assign, etc

from react-rxjs.

I'm closing this issue, let's continue the conversation in that PR/repo. Once again, thanks a lot @voliva !

from react-rxjs.

I've been playing with ESLint and AST for a bit and I got something working

At the moment what it does is just check that the function call is not happening inside a function or a class. It also handles:

• import { connectObservable as co } from 'react-rxjs' and then using co inside a component.
• import * as ReactRxJS from 'react-rxjs' and then calling ReactRxJS.connectObservable.
• It won't show up an error if connectObservable is being called without importing it (e.g. the consumer has defined a function with that name)

I tried pushing the code so far to the re-rxjs organization but I couldn't - so I created the repo in my account: https://github.com/voliva/eslint-plugin-react-rxjs. Happy to move it when we feel it's ready to publish 🚀. It would be great to have some feedback on what's in so far.

from react-rxjs.

This is awesome! Thanks a lot @voliva !

I tried pushing the code so far to the re-rxjs organization but I couldn't

🤔 I can see that you created a private-repo under the org:

but you can't push to it? Weird... I will look into the settings to make sure that you can do these things.

from react-rxjs.

It's so weird that you weren't able to push the code... Anyways, I have made the repo public, then I have put the commit-history of your personal repo into that one, and then I've opened this PR.

from react-rxjs.