Code Monkey home page Code Monkey logo

Comments (4)

josepot avatar josepot commented on May 25, 2024

It looks like this is in fact a problem with RN, not with react-rxjs: react-native-community/cli#1168. Also, according to the following comment:

For a package like uuid which does not contain react-native specific configuration in package.json this is not a problem, but for modules that do contain such config in package.json they will be forced to add package.json to their exports field.

I think that we should be ok? So, if everything works and the only issue is that the user gets a misleading warning, then I would prefer to wait for the RN team to address that issue rather than trying to create a workaround ourselves.

@hoclun-rigsep could you please let us know if -despite that warning- things work correctly?

from react-rxjs.

josepot avatar josepot commented on May 25, 2024

On a second thought: I guess that it doesn't hurt to include package.json on the list of exports, I can see how other libraries have done that. So, I guess that we can do the same...

from react-rxjs.

hoclun-rigsep avatar hoclun-rigsep commented on May 25, 2024

Okay, when I filed the issue I thought this was fatal, but that was late last night with a crying baby in my arms. It does appear to work despite the warning. Though I see you've patched it already, thank you! Now I can see the patch and see for myself what this issue is about.

from react-rxjs.

hoclun-rigsep avatar hoclun-rigsep commented on May 25, 2024

Do you wish me to close this?

from react-rxjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.