Code Monkey home page Code Monkey logo

Comments (16)

rdwatters avatar rdwatters commented on June 8, 2024 1

I think the only thing I didn't address was the potential for using a serif typeface for body copy, which is just something to try and haven't gotten there yet.

@budparr Are you talking about the warn and note admonitions? Not my admonitions from last night. Sorry again, brother 😉

from hugo-docs-concept.

budparr avatar budparr commented on June 8, 2024 1

I think you're saying that those are shortcodes and we need to account for them in the design. If so, noted. Thank you.

from hugo-docs-concept.

budparr avatar budparr commented on June 8, 2024 1

I've started to build a set of classes for shortcodes, partials (where they are component-like), and internal templates, where appropriate. So whatever is there, they will be designed for.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

I don't know if I mentioned this in the other thread, but this looks great!

What do you think about this?

#27

from hugo-docs-concept.

digitalcraftsman avatar digitalcraftsman commented on June 8, 2024

Created a separation between navigation/header and the content below.
Frankly, the navy blue might be too stark of a contrast, but a good starting place.

they should definitely be seperated visually

You added a shadow to the TOC on the right. The shadow let's make the TOC look more important that the actual content.

@budparr what do you think about experimenting with a different color pallet?

from hugo-docs-concept.

budparr avatar budparr commented on June 8, 2024

@digitalcraftsman Keep in mind that the above was just done with inspect in the browser, just to start thinking.

what do you think about experimenting with a different color pallet?

I think in this context the navy blue I used on the home page becomes overwhelming (I mentioned that above). So, yeah. We need to create that separation, but this may not be it. On the homepage, I think the dark color does a nice job of absorbing the extreme "colorfullness" of the logo.

You added a shadow to the TOC on the right. The shadow let's make the TOC look more important that the actual content.

Point taken.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

@budparr @digitalcraftsman @bep

I'm good with whatever design decisions you make on this 😄

from hugo-docs-concept.

bep avatar bep commented on June 8, 2024

I think it looks really really good, but it would be interesting to see the serif in use in body text in the doc pages as well. It may look odd or ... fantastic.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

@budparr what are your thoughts on the admonitions?

from hugo-docs-concept.

budparr avatar budparr commented on June 8, 2024

what are your thoughts on the admonitions?

I think the only thing I didn't address was the potential for using a serif typeface for body copy, which is just something to try and haven't gotten there yet.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

I think you're saying that those are shortcodes and we need to account for them in the design.

Yes, and perhaps for blockquotes as well. I want to eliminate the non-semantic use of <blockquote> for what are really CTAs, admonitions, etc.

The link for the admonitions above takes you to the contrib page with the examples. There is an optional title named parameter for each of the admonitions as well, although I'm not currently displaying them. It might make sense to add a third admonition for tip since this is a common use case. Thoughts?

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

@budparr Couple Qs:

  • With the new design you're working on, are you going to respect the same classes for the site navigation? See #44 for some context.

I've started to build a set of classes for shortcodes, partials (where they are component-like), and internal templates

  • Anything I should know w/r/t images/figures/video? I ask because I will be adding new content files today that will include screenshots and similar content, and it makes sense for me to use these now if this is what you're planning. As an aside, I built a pretty solid youtube shortcode {{yt}} that pulls in a thumbnail and then only injects the iframe after user interaction (big perf boost on slow mobile). It's in a private work repo, and I need to check the JS, but let me know if you think it has some utility for something like the blog. (My guess is the docs will have very few videos, at least for now). Thanks!

from hugo-docs-concept.

budparr avatar budparr commented on June 8, 2024

That youtube shortcode sounds great (I've got another project I can use it on!). I'll make sure that I respect any necessary classes.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

Called as such:

{{< yt id="123456" thumbnail="my-vid-thumb.jpg" description="My vid description" >}}

thumbnail and description are optional.

Example on temp page:

https://hugodocs.info/test

SCSS:
https://github.com/rdwatters/hugo-docs-concept/blob/master/pipeline/scss/components/_video.scss

Shortcode:
https://github.com/rdwatters/hugo-docs-concept/blob/master/layouts/shortcodes/yt.html

JS:
https://github.com/rdwatters/hugo-docs-concept/blob/master/pipeline/js/scripts/video-thumbnail-switch.js

NOTE You'll see a vimeo reference in the JS, which won't make a difference now. I had it working before, but perhaps vimeo changed their API. I'll need to look into this...in a few weeks. Cheers.

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

@budparr

In the interest of time (and of course we can change this as much as needed, I've at least lined up the colors per your suggested in-browser edits:

https://hugodocs.info/about/

from hugo-docs-concept.

rdwatters avatar rdwatters commented on June 8, 2024

@budparr Seems like your respective repositories are better places to have these discussions. Therefore, closing...

from hugo-docs-concept.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.