Code Monkey home page Code Monkey logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 23, 2024
You are right, its members should be protected. If someone tries to access 
members of
CCrashHandler::m_ThreadExceptionHandlers from main thread and from worker 
thread at
the same time, the app may crash. 

I plan to include this fix into v.1.2.1.

Original comment by [email protected] on 19 Dec 2009 at 4:11

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

from crashrpt.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 23, 2024
I reviewed the code another time...

Actually the members of CCrashHandler::m_ThreadExceptionHandlers shouldn't be
protected, because they are accessed from one thread only (from the thread that
installed exception handlers). Each thread accesses its own exception handlers 
by its
thread ID in 

std::map<DWORD, _cpp_thread_exception_handlers> m_ThreadExceptionHandlers;

However there is a danger that two threads will install exception handlers
concurrently and add items to the  m_ThreadExceptionHandlers at the same time. 
This
may cause crash. So, access to m_ThreadExceptionHandlers must be synchronized, 
I agree.

Original comment by [email protected] on 19 Dec 2009 at 4:25

  • Added labels: ****
  • Removed labels: ****

from crashrpt.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 23, 2024
Fixed in v1.2.1

Original comment by [email protected] on 23 Dec 2009 at 7:08

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

from crashrpt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.