Comments (3)
You are right, its members should be protected. If someone tries to access
members of
CCrashHandler::m_ThreadExceptionHandlers from main thread and from worker
thread at
the same time, the app may crash.
I plan to include this fix into v.1.2.1.
Original comment by [email protected]
on 19 Dec 2009 at 4:11
- Changed state: Accepted
- Added labels: ****
- Removed labels: ****
from crashrpt.
I reviewed the code another time...
Actually the members of CCrashHandler::m_ThreadExceptionHandlers shouldn't be
protected, because they are accessed from one thread only (from the thread that
installed exception handlers). Each thread accesses its own exception handlers
by its
thread ID in
std::map<DWORD, _cpp_thread_exception_handlers> m_ThreadExceptionHandlers;
However there is a danger that two threads will install exception handlers
concurrently and add items to the m_ThreadExceptionHandlers at the same time.
This
may cause crash. So, access to m_ThreadExceptionHandlers must be synchronized,
I agree.
Original comment by [email protected]
on 19 Dec 2009 at 4:25
- Added labels: ****
- Removed labels: ****
from crashrpt.
Fixed in v1.2.1
Original comment by [email protected]
on 23 Dec 2009 at 7:08
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from crashrpt.
Related Issues (20)
- Remove VS2005/ATL Compatibility HOT 2
- CrashRpt is not capturing Exact exception information some times. its crashed at crashHandler HOT 1
- Crashrpt not able to handle the Exceptions from ActiveX Controller call back in MFC . HOT 2
- can't make the crashreporter installed HOT 2
- No minidump created sometimes - reports "Only part of a ReadProcessMemory or WriteProcessMemory request was completed" HOT 1
- [deleted issue]
- Capture only windows belonging to the process HOT 1
- Czech localization HOT 2
- Potential crash in CrashSender.exe HOT 1
- uiAccess=true elevated process cannot create minidump HOT 1
- not compilable under Visual Studio 2013 HOT 5
- Include Polish translation (attached) HOT 1
- Redirects to a different server are not handled HOT 1
- If the crashsender is redirected, the crash report upload may happen twice.
- CrashCallback not working in VS 2013 HOT 3
- CrashSender crashes with access violation
- Can't make CrashRpt work with Qt HOT 1
- Translation files
- Setting bContinueExecution generates report twice
- can't open the crashfix server website HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crashrpt.