Code Monkey home page Code Monkey logo

Comments (11)

UnixJunkie avatar UnixJunkie commented on July 24, 2024

And so, how should we fix this?

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

Also, does this break something?
I just use rdkit from Python and it looks like it is working even if I use this brew installer.

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

A pull request to fix/improve this would be welcome.

from homebrew-rdkit.

YoshitakaMo avatar YoshitakaMo commented on July 24, 2024

This issue will be solved by adding -DCMAKE_INSTALL_RPATH=#{opt_lib}. See also Homebrew/homebrew-core#71694 .

And I recommend using homebrew-core's rdkit formula instead.

brew untap rdkit/rdkit # if required
brew install rdkit

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

@YoshitakaMo if you created a new brew formula for rdkit, and this is to be the standard one, maybe it should be announced on the rdkit-mailing list...
I was not aware of it, despite I try to maintain this recipe, which many people have contributed to over the years.

from homebrew-rdkit.

YoshitakaMo avatar YoshitakaMo commented on July 24, 2024

Since RDKit is now also used as a component of other programs such as Coot, I created a new RDKit formula as a byproduct of it.
Also, because the RDKit formula of this repository has not been updated recently and its syntax (e.g. install options such as --with-python3) became outdated, I had to create a new one to pass the homebrew-core's CI.
Although I have tried it with some test scripts, I cannot guarantee its full functionality since I am not a hard-core user of RDKit.

I would like to thank the long-time contributors of this formula. I'll consider announcing it on the mailing list.

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

Did you create your formula starting from this one?
If not, I will have to go look the differences, to check that what is here was also included in the new formula.
For example, the formula here even works on Linux homebrew !

The fact that in your new formula, several things are no more optional makes it quite slow to install (not everybody
requires PGSQL, the python wrappers, etc.).

Regards,
Francois.

from homebrew-rdkit.

YoshitakaMo avatar YoshitakaMo commented on July 24, 2024

Did you create your formula starting from this one?

Yes, I analyzed the rdkit formula here to create the new one. The basic functionalities are thus almost compatible, but I removed --with-java support and add a new option -DRDK_BUILD_YAEHMOP_SUPPORT=ON, which is used in the conda-rdkit.

For example, the formula here even works on Linux homebrew !

Thank you for this comment. Today I modified the new formula again to enable Linux OS to build rdkit from source. I tested it on my CentOS 7.8 and the installation was succeeded.

The fact that in your new formula, several things are no more optional makes it quite slow to install

I don't think it is such a big problem because homebrew-core provides a "bottle" of pre-compiled rdkit for each OS. This saves a lot of installation time, which is an advantage of using homebrew-core.

A bottle for Linux OS is not ready at this time for some reason, but I think homebrew-core/linuxbrew-core will generate it later.

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

You removed the java support because it doesn't compile on a Mac, right?
We have an issue here tracking that, though no solution:
#38

from homebrew-rdkit.

UnixJunkie avatar UnixJunkie commented on July 24, 2024

If you announce your recipe on the mailing-list, many people use the new formula and are happy with it, we might stop maintaining this repository and just pointing to the new one.

The fact that we don't need a tap anymore makes the install simpler.
Also, the new formula uses more modern syntax and looks simpler, embeds a test and enjoys the CI
tests of homebrew-core plus "bottles" !

from homebrew-rdkit.

YoshitakaMo avatar YoshitakaMo commented on July 24, 2024

You removed the java support because it doesn't compile on a Mac, right?

Yes, I removed it because I don't have a good idea to include java support. conda-rdkit neither.

If you announce your recipe on the mailing-list, many people use the new formula and are happy with it, we might stop maintaining this repository and just pointing to the new one.

Thanks @UnixJunkie and the contributors here. I will announce on the mailing-list in a few days.

from homebrew-rdkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.