Comments (6)
Okay. I've looked into this a bit more and the root cause is that the rdkit cartridge does not allow anything other than SMILES to be used in queries. Therefore it appears that a big chunk of the fields.py code is not correct as it tries to feed mol objects to queries when only SMILES would be accepted.
from django-rdkit.
thank you for the report, I'll have a look into this and I'll try to post some additional comments.
from django-rdkit.
After more digging, I was wrong -- the cartridge does allow pickled mol objects to be used in queries. The issue was that the current MolField functions weren't properly pickling them. I've got it working now by modifying the picking of objects.
from django-rdkit.
Thank you for submitting a PR, I was just about to suggest it. I'd leave this issue open until the PR is merged, if ok for you.
from django-rdkit.
Took awhile to get it working for all tests. After all that the key issue was a missing "mol_from_pkl" inside get_prep_value().
from django-rdkit.
Thank you the new version of the PR is not only more compact, but it also makes the intent clearer (and it fixes the tests, which was indeed an issue). I'll probably have a closer look at it again later today.
from django-rdkit.
Related Issues (20)
- Issue with Django 3 HOT 4
- Exact structure searches HOT 3
- Django Gist Index HOT 4
- New release for conda-forge package HOT 2
- Issue with migrate HOT 2
- Error preventing to move to django 4 (ugettext_lazy no longer supported)
- Migrations with Fingerprint Fields
- RDKit 2021.09 compatibility HOT 4
- problem generating molecule from blob data HOT 4
- Unable to set cartridge parameters through django_rdkit.config HOT 1
- Using Mol Field HOT 12
- MolField hassubstruct perfomance for complex molecules
- Using mol_adjust_query_properties()
- QMOL field
- Release as package on PyPI
- Documentation on RTD outdated
- Where to set do_chiral_sss? HOT 5
- NameError: name 'forms' is not defined HOT 1
- PyPI package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-rdkit.