Code Monkey home page Code Monkey logo

Comments (6)

rcrowley avatar rcrowley commented on July 3, 2024

Gauge in the JVM metrics is a generic, which would be great, and I guess we could make this one an interface{}, but I think the common case is an integer and that's served most users pretty well. (Case in point: you're the first to point this out.)

metrics.Meter is meant to capture the rate of events which are discrete events. Its Mark method records one or more events but the idea of recording 3.14159 events doesn't really make sense to me, even if the math works.

from go-metrics.

rcrowley avatar rcrowley commented on July 3, 2024

@usmanismail what if we added a new metric type that operates like Gauge but on an interface{}? Reporters would just format such metrics with "%v". Proposals for the name are welcome, too.

from go-metrics.

usmanismail avatar usmanismail commented on July 3, 2024

Its true that could work but we would be trusting the downstream code to return a valid interface otherwise Reporters will have to handle the garbled text.

As far as I can see the only missing usecase is floating point numbers. So maybe we can just add a FloatingPointGauge.

from go-metrics.

daniel-garcia avatar daniel-garcia commented on July 3, 2024

I've implemented a float64 version of Gauge. Please comment on #44 on the proposal.

from go-metrics.

daniel-garcia avatar daniel-garcia commented on July 3, 2024

There are many gauges which are not integers: temperature, stock/currency prices, loadavg, database settings, and just about any analog reading.

from go-metrics.

rcrowley avatar rcrowley commented on July 3, 2024

Closed per #44.

from go-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.