Assuming the regex always finds something about rpc-maas HOT 5 CLOSED

We can check for an empty list and use status_err.

I wonder if the script should also check the version of the tools installed.

Is there a minimum version number required? If so, wouldn't that be the responsibility of the script that installs OpenManage to ensure that the minimum version requirement is satisfied?

from rpc-maas.

@sigmavirus24 we can only say this plugin works for the versions we test. It strikes me as reasonable guard against unintended consequences.

from rpc-maas.

True, but we haven't been doing this for other plugins (one of which sticks out to me as being especially necessary (the percona toolkit which we use for galera_consistency has to be a certain version to work as expected)). Should we start adding this to each plugin that relies on a minimum version of a tool? I suspect it wouldn't take a great deal of effort.

from rpc-maas.

@sigmavirus24 good point on the other plugins. Spoke with @mancdaz who agrees it's worth it. I'd say we should specify a specific version instead of a minimum.

from rpc-maas.

So... as a side note, while running omconfig about to get the version number of OpenManage that we've been testing with, I see:

sh: 1: /bin/rpm: not found

start the output (but the exit code is still 0, since it prints the about information as expected). This isn't breaking anything but I figured I'd note it somewhere.

from rpc-maas.