I'm trying to run a stream capture example on arm64 device and getting this type of er

Hmm that looks to have been a bad change in <a class="commit-link" data-hovercard-type

Crash on mem::zeroed about libv4l-rs HOT 3 OPEN

raymanfx commented on July 23, 2024

Crash on mem::zeroed

from libv4l-rs.

Comments (3)

MarijnS95 commented on July 23, 2024 1

Hmm that looks to have been a bad change in 384e7fb, this struct isn't marked as repr(C) either.

If you look at enum Memory for example 0 isn't a valid bit-pattern, only values 1-4 are valid (anything else is UB):

libv4l-rs/src/memory.rs

Lines 12 to 19 in 9844291

    
           #[repr(u32)] 
        
           #[derive(Debug, Clone, Copy)] 
        
           pub enum Memory { 
        
               Mmap        = 1, 
        
               UserPtr     = 2, 
        
               Overlay     = 3, 
        
               DmaBuf      = 4, 
        
           }

@raymanfx is it okay if I replace these with default() once again?

from libv4l-rs.

MarijnS95 commented on July 23, 2024

Hmm it looks like the conversion from v4l2_buffer -> Metadata -> v4l2_buffer is also lossy.

from libv4l-rs.

MarijnS95 commented on July 23, 2024

For this specific case in mmap/stream.rs, I'm thinking of either wrapping it in MaybeUninit with // SAFETY docs about self.arena_index being valid, or wrapping it in an Option with an unwrap().

EDIT: Since there are user APIs passing arbitrary indices around, I'm leaning towards Option for additional validation.

from libv4l-rs.

Recommend Projects

Crash on mem::zeroed about libv4l-rs HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	#[repr(u32)]
	#[derive(Debug, Clone, Copy)]
	pub enum Memory {
	Mmap = 1,
	UserPtr = 2,
	Overlay = 3,
	DmaBuf = 4,
	}