Code Monkey home page Code Monkey logo

Comments (8)

raydac avatar raydac commented on August 16, 2024

and what do you use as child class? you have provided duplication of parent class instead of child class

from java-binary-block-parser.

raydac avatar raydac commented on August 16, 2024

if you have an array field then DSL builder needs information about length of the array and it should be provided through expression in extra attribute

 class BreakJBBPDslBuilder {
      @Bin(outOrder = 1, comment = "Reserved", type = BinType.BIT_ARRAY, extra = "4")
      public byte[] reserved;
    }

from java-binary-block-parser.

timmattison avatar timmattison commented on August 16, 2024

I will update that in a minute. But the child class should just have a single byte field in it.

from java-binary-block-parser.

timmattison avatar timmattison commented on August 16, 2024

Updated the child object. I was using this with the binary code I committed on another branch and the output I get from that is this:

breakJBBPDslBuilderChildArray [_] { BYTE reserved; } 

To me that makes the most sense. Can this be supported? I'd like to combine efforts here and have this wrapped into your library rather than maintain the external interface I built.

from java-binary-block-parser.

timmattison avatar timmattison commented on August 16, 2024

If you check out that branch and want to simply run this in a test to see what it does you can use this JUnit test code:

import org.junit.Test;

import java.io.IOException;

public class BinaryTest {
    @Test
    public void test1() throws IOException {
        System.out.println(new BreakJBBPDslBuilderParent().getFormat());
    }
}

from java-binary-block-parser.

raydac avatar raydac commented on August 16, 2024

I have improved message in the exception to provide more information what does mean the error and how to fix
Bin annotation can be used not only for DSL builder but also for JBBPOut so that it is important to provide all correct info in Bin annotation for a field

from java-binary-block-parser.

timmattison avatar timmattison commented on August 16, 2024

If the field is going to be an array without a fixed size (e.g. a structure that repeats 0 or more times) what is the size I should specify there? Do I use the underscore like the DSL?

from java-binary-block-parser.

raydac avatar raydac commented on August 16, 2024

if array should be read till end of stream then underscore should be used, extra="_"

from java-binary-block-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.