Issue parsing specific text combinations from script about script-commands HOT 5 CLOSED

I am on Catalina. I think you are on to something. I believe it just so happens that the character combination I generate introduces a + symbol in the base64 encoded string.

https://ray.so/?colors=midnight&background=true&darkMode=true&padding=64&title=Untitled-1&code=PD9waHAKCnNwcmludGYoIkhlbGxvIDxmZz15ZWxsb3c+JXMiLCAid29ybGQiKTsK

This will fail (because I think the browser interprets the + symbol as a space.

But when I urlencode the base64 encoded value:

https://ray.so/?colors=midnight&background=true&darkMode=true&padding=64&title=Untitled-1&code=PD9waHAKCnNwcmludGYoIkhlbGxvIDxmZz15ZWxsb3c%2BJXMiLCAid29ybGQiKTsK

It works!

Based on that it seems the solution is to replace any + symbols in the generated CODE query parameter with %2B. According to this doc, the only valid output character for a base64 encoded string that would need to be urlencoded is the +, so this primitive approach seems adequate.

I can confirm that editing the script to this on lines 36 and 37 solves it (note I just added a bash replace-all syntax to the $CODE variable here to replace any + with %2B).

CODE=$(pbpaste | base64)
CODE=${CODE//+/%2B}

Let me know if you'd like me to make a pull request for this.

from script-commands.

Follow up on this. I ran a test in order to determine whether base64 was mangling the content before sending it. I added an echo $CODE in the script to see what it was producing. I got the string PD9waHAKCnNwcmludGYoIkhlbGxvIDxmZz15ZWxsb3c+JXMiLCAid29ybGQiKTsK

When I run base64 --decode on it I get the expected results. So the correct string is being sent up to the server:

$ echo PD9waHAKCnNwcmludGYoIkhlbGxvIDxmZz15ZWxsb3c+JXMiLCAid29ybGQiKTsK | base64 --decode
<?php

sprintf("Hello <fg=yellow>%s", "world");

Edit: corrected example output

from script-commands.

Thanks for flagging this. I think the problem is that the open command doesn't properly URL encode the query params. Are you on macOS Big Sur?

from script-commands.

Ah this is brilliant. Please go ahead and submit a PR. Your solutions seems very elegant. Please reference this issue in the PR and then we can close it when it got merged.

Thanks a lot for digging into it. Super appreciated.

from script-commands.

PR merged 👏

from script-commands.