Comments (5)
rbenitezpagan
commented on May 18, 2024
1
@raviriley Yes, I'll work on it. Assign it to me. 👍
The implementation basically just added [site.locale] to the site.data.sitetext.<var> = site.data.sitetext[site.locale].<var> so it was not really a major change.
from agency-jekyll-theme.
fmitchell
commented on May 18, 2024
1
Letting you all know that I think this commit 34e5e85 broke my site that, I believe, is still dependent on the old structure.
Screenshot: https://share.getcloudapp.com/qGuJPPyb
The menu, middle section, and some other parts don't show up. I'm going to attempt to fix it based on the changes in that PR.
from agency-jekyll-theme.
rbenitezpagan
commented on May 18, 2024
1
@raviriley This fell of my radar. You are welcome to tackle it.
I think you could add a default with site.data.sitetext.<var> and that should be enough.
from agency-jekyll-theme.
raviriley
commented on May 18, 2024
Sounds good, thanks @rbenitezpagan!
from agency-jekyll-theme.
raviriley
commented on May 18, 2024
Thanks @fmitchell! This issue is high priority. @rbenitezpagan I can take this if you'd like!
from agency-jekyll-theme.
Related Issues (20)
- How to get to the code behind the theme HOT 2
- 1. Add, Remove or Change Order of Sections HOT 3
- 2. Copyright footer and chrome website tag to show custom url and not ".github.io" HOT 2
- About section does not appear on the main page HOT 2
- Links not working if you visit legal HOT 2
- No way to edit About HOT 11
- Gem-based installation seems broken HOT 3
- Custom pages with language support HOT 1
- Local dev environment working great, but Github Pages gives 404 HOT 1
- Smarter/dynamic team member layout HOT 7
- How should I create jekyll-scholar file structure ? HOT 3
- The jekyll-agency theme could not be found. (Jekyll::Errors::MissingDependencyException) HOT 4
- Can't this theme be applied directly on Github Pages? HOT 1
- Whitespace characters as default value in contact form
- Switching default locale to German HOT 7
- Ability to override fonts HOT 5
- No Index.html? HOT 5
- Is it possible to add a blog section HOT 1
- How to edit the HTML code ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agency-jekyll-theme.