Code Monkey home page Code Monkey logo

Comments (7)

rappasoft avatar rappasoft commented on June 7, 2024 1

Thanks I will fix the docs today! I'll try to look into your full page components issue.

from laravel-livewire-tables.

KenKodz avatar KenKodz commented on June 7, 2024 1

LOL ... It's been a long day. Didn't even occur to me. I guess it's time for a break.

from laravel-livewire-tables.

KenKodz avatar KenKodz commented on June 7, 2024

I didn't have time to test it out today but I "should" tomorrow. I did look through the diff and I like the extra flexibility you allow. If this conversation is still open tomorrow, I'll provide some feedback from firsthand use.

Thanks for all your hard work on this!

from laravel-livewire-tables.

rappasoft avatar rappasoft commented on June 7, 2024

Yes please do, I might end up doing a release tonight if I have time. I look forward to your feedback to make this as good as it can be!

from laravel-livewire-tables.

KenKodz avatar KenKodz commented on June 7, 2024

After a couple of hours of working with it, here's my feedback.

Functionally, it works great and meets most of my needs. I really like the improved flexibility in the Column class.

However, here's a couple notes regarding the documentation for Defining Columns:

  • The make method documentation is missing. It was in previous versions.
  • The format method is expecting a callable but the docs show that it's expecting Model and Column.

That's all I've got for now. I do think it's a big improvement. I have other ideas for additional functionality that I haven't had much time to work on yet (e.g. #64). As soon as I'm able, I will add an issue with each idea to see if it's something you'd be interested in adding to the package before I start working on it.

Thank you for all your hard work building this!

from laravel-livewire-tables.

KenKodz avatar KenKodz commented on June 7, 2024

I just noticed that the Table trait methods don't do anything. They all return null or []. It was like that in the last version too, but we were able to access the properties. Now there are only 2 properties. I only noticed this now because I was working to "entangle" the table with my alpine code.

from laravel-livewire-tables.

rappasoft avatar rappasoft commented on June 7, 2024

Are you overriding them on your table?

public function setTableHeadClass($attribute): ?string
    {
      if ($attribute === 'name') {
             return 'table-success';
     }

        return null;
    }

from laravel-livewire-tables.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.