[FEA] upgrade CUDA stream pool about raft HOT 6 CLOSED

You would never use rmm::cuda_stream for a function parameter, as it is an owning wrapper. You would use it (or rmm::cuda_stream_pool) for creating streams. For function parameters, use rmm::cuda_stream_view, which is implicitly constructable from cudaStream_t and so should not break your APIs.

from raft.

I'm all in favor of code reuse. I don't see any big issues with this in cuML. But I'd like to hear from @cjnolet on this one. Because, in MNMG algo's like kNN we end up querying for all of the streams at once and then use them to launch work onto GPUs!

re: API to acquire a stream from the pool

FWIW, the proposed get_stream approach should just work fine with cuML.

from raft.

Also please consider using rmm::cuda_stream and rmm::cuda_stream_view in RAFT, cuML, and cuGraph as well.

from raft.

Sounds like a good idea. The only caveat is that using rmm::cuda_stream will cause a ripple change in all of RAFT/cuML/cuGraph, as we expose a cudaStream_t on almost all methods! Maybe in the interim we could just use the underlying cudaStream_t object from rmm::cuda_stream? Is that possible @harrism ?

from raft.

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

from raft.

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

from raft.