Comments (6)
You would never use rmm::cuda_stream
for a function parameter, as it is an owning wrapper. You would use it (or rmm::cuda_stream_pool
) for creating streams. For function parameters, use rmm::cuda_stream_view
, which is implicitly constructable from cudaStream_t
and so should not break your APIs.
from raft.
I'm all in favor of code reuse. I don't see any big issues with this in cuML. But I'd like to hear from @cjnolet on this one. Because, in MNMG algo's like kNN we end up querying for all of the streams at once and then use them to launch work onto GPUs!
re: API to acquire a stream from the pool
FWIW, the proposed get_stream
approach should just work fine with cuML.
from raft.
Also please consider using rmm::cuda_stream
and rmm::cuda_stream_view
in RAFT, cuML, and cuGraph as well.
from raft.
Sounds like a good idea. The only caveat is that using rmm::cuda_stream
will cause a ripple change in all of RAFT/cuML/cuGraph, as we expose a cudaStream_t
on almost all methods! Maybe in the interim we could just use the underlying cudaStream_t
object from rmm::cuda_stream
? Is that possible @harrism ?
from raft.
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.
from raft.
This issue has been labeled inactive-90d
due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
from raft.
Related Issues (20)
- [FEA] CAGRA vector addition - support large graph and dataset
- [FEA] Additional distance metrics for CAGRA, CAGRA-Q
- [FEA] NN Descent + CAGRA should support additional distance metrics
- [QST] Parallel Execution of cugraph::bfs Using RAFT and OpenMP for Stream Management
- [FEA] Support for (u)int8 matrix in row_normalize
- [QST] How to change log level in pylibraft
- [QST] num_threads on ANN latency benchmark HOT 2
- error loading pylibraft HOT 1
- [BUG] IVF-PQ index creation crashes on aarch64 for wiki_all_1M benchmark HOT 1
- [FEA] Better exception handling
- [FEA] use of COO to balance the `faster_dot kernel` across the blocks
- [FEA]creating the masked_matmul function to front the SDDMM+custom kernel.
- [BUG] wheel tests do not fail when `raft-dask` wheel has unsatisfiable dependency requirements HOT 1
- [BUG] Error when running raft_ann_bench
- [BUG] Enable logging macros in downstream projects
- [BUG] Cagra To hnsw, the search api not use search param ef HOT 3
- [FEA] Consolidate SUM reductions across raft
- [BUG] `bitmap_view::set` not work
- [FEA] Support setting the bits in a bitmap filter via a user-defined CUDA functor.
- Updating RAFT ANN benchmark environment/containers to newer CUDA
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raft.