vim background color is not correct about rio HOT 6 CLOSED

It might cause to use true color theme. 24bit colors are rendered by following codes.

• fg
  

  rio/rio/src/screen/state.rs

  Line 122 in ec4f89d

  AnsiColor::Spec(_rgb) => self.named_colors.foreground,

• bg
  

  rio/rio/src/screen/state.rs

  Line 135 in ec4f89d

  AnsiColor::Spec(_rgb) => self.named_colors.foreground,

fg and bg are same, so we looks like no characters on screen.

I tried fixing with ColorRGB::to_arr(), example of function to convert to ColorArray.

impl ColorRgb {
    pub fn to_arr(&self) -> ColorArray {
        [
            self.r as f32 / 255.0,
            self.g as f32 / 255.0,
            self.b as f32 / 255.0,
            1.0
        ]
    }
}

Here is example.

from rio.

@raphamorim fixed in the canary build!

from rio.

Can't reproduce on my vim but my nvim is having similar issues. Probably is some missing instruction in the Rio to deal with specific configuration (my vimrc and nvim configs are different)

My VIM

from rio.

good catch @niuez yes, rgb colors are being completely ignored (I can reproduce it as well).

Would mind send a PR correcting it in the AnsiColor::Spec(_rgb) => self.named_colors.foreground to use ColorRgb with to_arr as you suggested or extend ColorBuilder

from rio.

@siimon can you validate if it still happens with the canary release build? https://github.com/raphamorim/rio/releases

from rio.

Great! thank you for confirming @siimon

from rio.