Comments (5)
Resizing the window also triggers a lot of rerenders.
Screencast.from.2024-01-28.16-40-10.webm
from rio.
Good findings, yes those behaviors should be fixed. Now cursor can come either from terminal and state, most of times comes from state, but would be good move part of cursor rendering logic outside of state (state reflects in the current window rendering state).
from rio.
Are the changes required affected by #428?
I also noticed selecting text is a lot slower when blinking-cursor
is turned on.
Turned off:
Screencast.from.2024-01-28.23-58-52.webm
Turned on:
Screencast.from.2024-01-28.23-59-41.webm
It is not a problem when using nvim or zellij, which I am guessing is because they handle cursor state themself (?).
Edit:
Adding a check for whether there is a selection eliminates the delay after first render.
rio/frontends/rioterm/src/screen/mod.rs
Lines 1254 to 1256 in 4ad69ff
if self.state.has_blinking_enabled
&& has_blinking_enabled
&& self.selection_is_empty()
{
self.context_manager.schedule_render(800);
}
I am not sure whether this is a desired long term solution, but it might make sense as a quick fix?
from rio.
Are the changes required affected by #428?
No shouldn't be affected, #428 should touch mostly sugarloaf crate.
I also noticed selecting text is a lot slower when blinking-cursor is turned on.
Hmm, that would make sense because is stacking rendering and blinking (rendering) in the same time.
Adding a check for whether there is a selection eliminates the delay after first render.
I like the solution for now but shouldn't be the final fix (I guess) because could be that users would expect the cursor to blink if have selected text (?? not sure tbh).
Would you mind create a PR with those changes?
from rio.
Sure, coming up.
from rio.
Related Issues (20)
- Glyphs have very weird rendering HOT 6
- Layout support HOT 1
- Linux Wayland: WA migration
- Linux X11: Wa migration
- Windows: WA migration
- Fix cached run on lines that crashes few times [sugarloaf] HOT 1
- Load emoji and falllback fonts on demand and drop memory after not being used anymore leaving only the file path as reference
- Are ligatures actually supported in 0.0.36? HOT 3
- newline issue when pasting multi-line text HOT 2
- [Bug] Noticeable text update HOT 12
- [Bug] Noticeable text update
- [Bug] Tab indicator doesn't disappear HOT 2
- [Bug] The `[colors]` option does not override theme colors. HOT 3
- zsh with glyphs won't render HOT 8
- Changing zellij pane with <alt> + arrow does not work HOT 3
- [Feature] Add support for choosing font width HOT 1
- When init ssh session backspace and navigation with ctrl dont work as expected HOT 2
- Visible lines on transparent background HOT 5
- Delete key doesn't work in kitty mode
- Odd background transparency on macOS (Intel) HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rio.