Comments (7)
ranyitz
commented on June 25, 2024
1
Hey @nelson6e65, thanks for opening this issue!
It seems that the logic on this line is wrong, instead of using the path module, we should just join the directory name and the module name with / regardless of the environment (windows/linux/mac).
I believe this will solve both this issue and #97
@nelson6e65 would you be interested in contributing a PR that fixes this?
from qnm.
nelson6e65
commented on June 25, 2024
1
Hello, @ranyitz I have a pre-pr 😅
I detected an issue when I cloned the repository to a directory with spaces. Can you check if my "solution" on #99 is Ok?
from qnm.
ranyitz
commented on June 25, 2024
1
@nelson6e65 yeah, it seems that I don't have a windows CI setup here, I'll try to add one soon (similar to this setup here).
from qnm.
ranyitz
commented on June 25, 2024
1
Fixed on #100 and released on v2.6.0
from qnm.
nelson6e65
commented on June 25, 2024
Sure.
from qnm.
nelson6e65
commented on June 25, 2024
I don't know if you want I complete all Windows compatibility or merge #99 as a pre-fix (some tests are able to run, but others are still failing on Windows). 😅
from qnm.
nelson6e65
commented on June 25, 2024
Nice. I moved to GitHub Actions some time ago. 😅
In the meantime, I will continue on this issue later this night.
from qnm.
Related Issues (20)
- FR: Support for monorepos within subdirectory? HOT 15
- Dedupe the reasons for a module to be installed
- Use Ellipsis when there are more than 3 reasons for having a module HOT 1
- ENAMETOOLONG: name too long, scandir xxx HOT 1
- Add pnpm support? HOT 8
- Bring back shell autocompletions HOT 1
- Should this work in Windows Anaconda? HOT 3
- What does count actually mean? HOT 3
- Option `--disable-colors` seems not to be working HOT 1
- fish completions command error HOT 1
- find version in node javascript HOT 1
- Recently changed dependencies HOT 5
- Add a way to include bundled dependencies HOT 5
- Mark a dependency with (resolutions) in case it's affected by yarn's resolutions
- Mark a dependency with (overrides) in case it's affected by npm's overrides
- Idea: Display nohoist indication for packages that affected by the nohoist configuration HOT 1
- Support parsing yarn 3 lock files
- Bug: qnm spawns check.js which eats CPU HOT 3
- Windows: Unable to use on scoped packages HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qnm.