Code Monkey home page Code Monkey logo

Comments (12)

randym avatar randym commented on September 7, 2024

That's a great start!

I think serious thing I would ask is that the source files for the class be moved into lib/axlsx/workbook/worksheet/ as the table is a part of a worksheet.

After the release this evening, why don't we setup a branch and merge that in?

Ill set you up with access so you can work directly against the repository.

from axlsx.

jurriaan avatar jurriaan commented on September 7, 2024

Hmm, I was thinking where to place those files. I agree the worksheet folder is a better place :)

from axlsx.

randym avatar randym commented on September 7, 2024

hey @jurriaan are you ready to merge this in?
I think we should just drop it in master and see how things work out.

I would expect that if you are interested in using table objects some work should be done with the styles for table formats as well.

from axlsx.

jurriaan avatar jurriaan commented on September 7, 2024

I'm ready for it, but it's not fail proof yet.. Excel doesn't accept all characters as Table title.. Can't find good doc's/specs on it.

from axlsx.

jurriaan avatar jurriaan commented on September 7, 2024

I'll look at this today and do a pull request ;)

from axlsx.

randym avatar randym commented on September 7, 2024

Awesome! Table support will really pave the way for automated table styles which makes it much easier for everyone!

from axlsx.

jurriaan avatar jurriaan commented on September 7, 2024

See #55

from axlsx.

randym avatar randym commented on September 7, 2024

merged and specs passing on travisci. Unfortunately some kind of error when opening example.xlsx
Seems Excel for Mac does not support tables/table styles in my crappy Office Mac 2008 version

from axlsx.

jurriaan avatar jurriaan commented on September 7, 2024

That's weird, I think the problem is that it uses a style which isn't defined in the xlsx itself. Maybe 2008 doesn't know about that style

from axlsx.

randym avatar randym commented on September 7, 2024

erros - in Japanese

テーブルへ構造化参照
Excel 表
テーブルのスタイル

from axlsx.

randym avatar randym commented on September 7, 2024

fair enough, it is simply not supported pre 2011 on mac
http://mac2.microsoft.com/help/office/14/ja-jp/excel/item/96392f0e-455b-42c9-81a7-4adedef56011?category=7c8ab934-6daa-4c4a-87a9-d748583caa30

word of warning to all!

from axlsx.

randym avatar randym commented on September 7, 2024

first run table support is DONE!

Thanks a million @jurriaan

from axlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.