Code Monkey home page Code Monkey logo

Comments (10)

randym avatar randym commented on July 17, 2024

@crishoj Great Stuff Mate!

I think testing at that level is the best thing to do with this kind of issue, but the idea that the @builder is cached between requests seems odd to me.....

I expected that this:

https://github.com/randym/activeadmin-axlsx/blob/master/lib/active_admin/axlsx/builder.rb#L167

Would cache the axlsx package for the request, and allow you to add charts, and to other cool design/image/pivot table/chart stuff before sending it off to the client.

But if subsequent requests are adding rows... hmmm....

from activeadmin-axlsx.

crishoj avatar crishoj commented on July 17, 2024

crishoj/activeadmin-axlsx@a17aaae provides a test case for this.

I'm not completely satisfied by my proprosed fix, though, as it makes it rather clumsy to reconfigure the default builder. What are your toughts on this?

from activeadmin-axlsx.

matteofuzz avatar matteofuzz commented on July 17, 2024

Any news?

from activeadmin-axlsx.

follmann avatar follmann commented on July 17, 2024

Great gem! But same problem here. Any development?

from activeadmin-axlsx.

randym avatar randym commented on July 17, 2024

On it!

Sorry for being so freaking slow!

from activeadmin-axlsx.

randym avatar randym commented on July 17, 2024

This is fixed in master as of 7154782

Can I ask you to pull from github and confirm? If everything looks good, I'll release a new version.

from activeadmin-axlsx.

matteofuzz avatar matteofuzz commented on July 17, 2024

I tested it on Rails 3.2.12 and ActiveAdmin 0.6.0 and seem all OK.

Thanks a lot, great gem, we AA users need it.

from activeadmin-axlsx.

follmann avatar follmann commented on July 17, 2024

@randym No need for apologizing! Anyone maintaining an open source project understands the effort behind it. Thanks for the update! I can also confirm the fix works for AA 0.6 and Rails 3.2.13. Are you gonna release it?

from activeadmin-axlsx.

randym avatar randym commented on July 17, 2024

Hi all,

I'll be releasing this weekend. Thanks for everyone's patience!

from activeadmin-axlsx.

randym avatar randym commented on July 17, 2024

released

from activeadmin-axlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.