Comments (10)
@crishoj Great Stuff Mate!
I think testing at that level is the best thing to do with this kind of issue, but the idea that the @builder is cached between requests seems odd to me.....
I expected that this:
https://github.com/randym/activeadmin-axlsx/blob/master/lib/active_admin/axlsx/builder.rb#L167
Would cache the axlsx package for the request, and allow you to add charts, and to other cool design/image/pivot table/chart stuff before sending it off to the client.
But if subsequent requests are adding rows... hmmm....
from activeadmin-axlsx.
crishoj/activeadmin-axlsx@a17aaae provides a test case for this.
I'm not completely satisfied by my proprosed fix, though, as it makes it rather clumsy to reconfigure the default builder. What are your toughts on this?
from activeadmin-axlsx.
Any news?
from activeadmin-axlsx.
Great gem! But same problem here. Any development?
from activeadmin-axlsx.
On it!
Sorry for being so freaking slow!
from activeadmin-axlsx.
This is fixed in master as of 7154782
Can I ask you to pull from github and confirm? If everything looks good, I'll release a new version.
from activeadmin-axlsx.
I tested it on Rails 3.2.12 and ActiveAdmin 0.6.0 and seem all OK.
Thanks a lot, great gem, we AA users need it.
from activeadmin-axlsx.
@randym No need for apologizing! Anyone maintaining an open source project understands the effort behind it. Thanks for the update! I can also confirm the fix works for AA 0.6 and Rails 3.2.13. Are you gonna release it?
from activeadmin-axlsx.
Hi all,
I'll be releasing this weekend. Thanks for everyone's patience!
from activeadmin-axlsx.
released
from activeadmin-axlsx.
Related Issues (20)
- Trailing zeros in column values HOT 1
- Custom helpers not being included, compass watch produces an error. HOT 1
- Active Admin scoped_collection HOT 2
- get data for pivot table from another sheet in after_filter hook HOT 1
- Not working with AA 1.0.0.pre HOT 3
- Breaking Routes
- Gemfile incompatible with activeadmin master/pre branch HOT 1
- `require': cannot load such file -- activeadmin/axlsx (LoadError) HOT 1
- wrong number of arguments (1 for 0) HOT 14
- "wrong number of arguments (1 for 0)", activeadmin (1.0.0.pre) ruby 2.1.2 and rails 4.1.5 HOT 2
- undefined local variable or method `max_csv_records' in AA 1.0.0.pre HOT 3
- The way to make activeadmin-axlsx work with newest ActiveAdmin 1.0 Rails4 (Tested) HOT 1
- Using only filtered elements in the excel download
- Using activeadmin-axlsx with ActiveAdmin version 1.0.0.pre1 causes a crash HOT 4
- two issues with devise
- index_without_xlsx(options) fails with wrong number of arguments (1 for 0) HOT 1
- 2.0.1 seems to break font-awesome-rails
- Excel cant open this file format error
- dependency was wrong
- Installation dependency axlsx is not recognized
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from activeadmin-axlsx.