Q: Why does the example for Maybe.cata and Result.cata divide the input height by 2.2? about pratica HOT 4 CLOSED

@khtan Do you have any suggestion on how to make it more clear?

from pratica.

Hi Rametta, sorry for not responding in time. Hope you can still read my comment and respond.

This is the original code:

isOver6Feet({ height: 4.5 })
  .map(h => h / 2.2)
  .cata({
    Just: h => console.log(h), // this function doesn't run
    Nothing: () => console.log(`person is not over 6 feet`)
  })

Suggestion 1:
Use 2 examples, one with height 4.5, the other with height 7.5 to show the
2 branches of the code, and following the pattern of your original comments

isOver6Feet({ height: 4.5 })
  .cata({
    Just: h => console.log(h), // this function doesn't run
    Nothing: () => console.log(`person is not over 6 feet`)
  })
isOver6Feet({ height: 7.5 })
  .cata({
    Just: h => console.log(h), // prints 7.5
    Nothing: () => console.log(`person is not over 6 feet`) // this function doesn't run
  })

Suggestion 2:
Take out the map(h => h /2.2 ) because it does not add to the understanding how Maybe is used.
In fact it raises more questions like
a. Is 2.2 an arbitrary constant or a conversion factor
b. Since the height is in feet, is 2.2 a conversion from imperial to metric
etc

from pratica.

@khtan perhaps you can open a PR with your suggestion? Would be very helpful!

from pratica.

from pratica.