Comments (6)
I ran into the exact same thing. People issued pull requests on dev when they should have been using master. Feature branches merging into a master branch is just simpler.
from psdeploy.
But you should be pulling to the dev branch, right? That's the whole point of a dev branch (which is just a generic feature branch). When you have enough pulls on dev that you want to go live the owner does a pull from the dev branch to the master?
That's my understanding.
from psdeploy.
Yep! The problem is that we can't control what branch folks work from, or submit a pull request against - it can be dissuading to them to turn around and say redo this against dev. Particularly if they're new to git or GitHub.
With just prod, there can be no mistakes, and we can accept PRs on demand, no need to accept+merge-to-master-at-some-point.
Cheers!
from psdeploy.
True, but somehow just doesn't feel right. I have an open PR to dev, want me to refork off master and resubmit?
from psdeploy.
Nope! I'l go ahead and merge that, merge dev into master, update contributing references to dev branch, and kill dev branch.
Timing wise, might be next week; a bit busy wrapping up before holiday break during work, and last minute shopping and prep after work.
Cheers!
from psdeploy.
Deleted and updated docs, we'll work off master now.
I'll try to keep my own commits, barring minor changes (I know...) to branches to avoid any issues - everyone else can treat the fork as a branch, and submit the PR to master.
Cheers!
from psdeploy.
Related Issues (20)
- DependingOn not working as expected (ordering wrong) HOT 5
- AppVeyor deployment not supporting subfolder for nupkg HOT 1
- Deployment fails on Linux HOT 3
- Move FileSystem tests out of the main function tests.
- Appveyor module fails when running in Powershell 6.0 HOT 1
- AppVeyor deployment: NuGet: An error occurred while parsing EntityName errors
- Shadow-Copy Function Throws Exception when run on PS Core on Linux or OSX HOT 7
- [Suggestion] Using name instead of path parameter in PSGalleryModule deployment type
- Invoke-Robocopy FatalError with /xf parameter
- Search for *psdeploy.ps1 is case sensitive on Unix systems
- GitHub Release DeploymentType HOT 2
- Please upgrade to latest YamlDotNet
- New Deployment Type: Azure Automation runbook HOT 2
- My psd1 version and psgallery version don't update.
- RequiredModules breaks PSGallery deploy type to private nuget repo HOT 1
- By Filesystem on PS Core fails with error HOT 1
- Upcoming major releases of Chocolatey products that may impact functionality on the integration HOT 1
- New Deployment Type: SCP HOT 2
- Filter deploy based on Tag/TagName and pre-release status HOT 7
- PSGalleryModule - Make ApiKey optional HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psdeploy.