Code Monkey home page Code Monkey logo

Comments (6)

ngetchell avatar ngetchell commented on August 23, 2024

I ran into the exact same thing. People issued pull requests on dev when they should have been using master. Feature branches merging into a master branch is just simpler.

from psdeploy.

martin9700 avatar martin9700 commented on August 23, 2024

But you should be pulling to the dev branch, right? That's the whole point of a dev branch (which is just a generic feature branch). When you have enough pulls on dev that you want to go live the owner does a pull from the dev branch to the master?

That's my understanding.

from psdeploy.

RamblingCookieMonster avatar RamblingCookieMonster commented on August 23, 2024

Yep! The problem is that we can't control what branch folks work from, or submit a pull request against - it can be dissuading to them to turn around and say redo this against dev. Particularly if they're new to git or GitHub.

With just prod, there can be no mistakes, and we can accept PRs on demand, no need to accept+merge-to-master-at-some-point.

Cheers!

from psdeploy.

martin9700 avatar martin9700 commented on August 23, 2024

True, but somehow just doesn't feel right. I have an open PR to dev, want me to refork off master and resubmit?

from psdeploy.

RamblingCookieMonster avatar RamblingCookieMonster commented on August 23, 2024

Nope! I'l go ahead and merge that, merge dev into master, update contributing references to dev branch, and kill dev branch.

Timing wise, might be next week; a bit busy wrapping up before holiday break during work, and last minute shopping and prep after work.

Cheers!

from psdeploy.

RamblingCookieMonster avatar RamblingCookieMonster commented on August 23, 2024

Deleted and updated docs, we'll work off master now.

I'll try to keep my own commits, barring minor changes (I know...) to branches to avoid any issues - everyone else can treat the fork as a branch, and submit the PR to master.

Cheers!

from psdeploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.