Comments (1)
Hi, thanks for reporting. I can confirm that this is a bug in https://github.com/raineorshine/npm-check-updates/blob/main/src/lib/upgradePackageDefinitions.ts. It seems that when eslint-plugin-import
is removed from the upgrade list due to its peerDependency on eslint
, eslint-plugin-unused-imports
accidentally gets added to the upgrades without being checked for peer compatibility.
Unfortunately I'm not super familiar with this feature, since I wasn't the original implementator. It's tricky because when any dependency is upgraded, the peerDependencies need to be checked again. I'm wondering if we should be upgrading dependencies one at a time and checking peerDependencies immediately after, rather than trying to upgrade them all and then iterating until peerDependencies do not change.
The next step would be to create a breaking unit test for this test case. Then we can attempt a solution. I don't have the bandwidth for this at the moment, but hopefully someone with some free time can take a stab at it.
from npm-check-updates.
Related Issues (20)
- [Feature] Allow fully resolved custom/non-repo urls to display with --format repo HOT 1
- Suggestion: Add `packageManager` to the default value of `--dep` HOT 1
- How to update `package.json` with versions already installed in `package-lock.json`? HOT 2
- backup old package json HOT 1
- Could not read peer dependencies for package when combining --cwd with --peer HOT 2
- bun.cmd id not recognized HOT 6
- --pre 0 updates to beta package HOT 2
- Bad export of generated JavaScript file HOT 11
- Monorepo/workspaces support via config path specification CLI arg HOT 1
- security vulnerability using [email protected] HOT 1
- Do not exceed upper bound of range when using --target semver
- ncu --doctor show the help HOT 3
- No npm "test" script defined. You must define a "test" script i HOT 3
- interactive CLI has no quit or exit command. HOT 4
- Tie updates of Definitely Typed `@types/` packages to their corresponding code package HOT 3
- Only the first workspace package is checked HOT 2
- yarn package manager is missing getPeerDependencies
- when packages are filter due to engine not matching, we need to print it out, just like we do in peer checks
- [Windows] CLI doesn't work if directory contains `node.js` file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from npm-check-updates.