Comments (2)
Hi DaanA32,
nice things in your commit!
To be honest, I haven't put much thought into a support for a different architecture. I'm still working on the x86 implementation and this will take some time.
But this is definitely something I want to do in the future. Maybe I would go with the cfg feature of Rust.
Also a pure software based implementation as a fallback would be nice, to support CPUs without the AES extension (like the Raspberry you mentioned).
But this would purely for freedom of mining reasons (everybody with a CPU should be able to mine Monero). I'm currently focusing on performance and I guess this is something not in the near future.
from mithril.
I would suggest either using cnf_if for the aes part of m128i
eg:
pub fn aesenc(&self, key: m128i) -> m128i {
cnf_if {
if #[cfg(target_feature='crypto')] {
// HARDWARE IMPL
} else {
// SOFTWARE IMPL
}
}
}
Or a trait based approach
#[cfg(target_feature='crypto')]
trait Aes for m128i {
// HARDWARE IMPL
}
#[cfg(not(target_feature='crypto'))]
trait Aes for m128i {
// SOFTWARE IMPL
}
from mithril.
Related Issues (20)
- gcc problem ? HOT 1
- Is this some relationship with mimblewimble? HOT 1
- add #![feature(i128_type)] to the crate attributes to enable HOT 2
- Thread Affinity HOT 2
- Pure AES implementation HOT 4
- Windows: error on startup HOT 1
- MacOS: Config file not found error HOT 4
- MacBook Pro 2018 6-core i7 when running "cargo build --release" HOT 3
- Possible to add more Alt-coin algorithm to this project? HOT 5
- hard-fork v8 update missing
- hard-fork march/2019 update missing HOT 1
- Use of depricated function within a library HOT 4
- JH Hashing HOT 2
- Questions regarding this project. HOT 8
- Is this program designed so I can import it as a crate? HOT 3
- How to start it HOT 1
- Why the old rust edition? HOT 2
- Incorrect ScInstr attribute for IMULH_R & ISMULH_R
- Hashrate issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mithril.