Dropping gnome-icons.css about firefox-gnome-theme HOT 16 CLOSED

Why would the code using the SVG not be simply put in gnome-icons.css?

from firefox-gnome-theme.

gnome-icons.css was out of "core" because it was partially broken, the SVG implementation will not.
So no reason to continue out. Or do you think most people prefer default Firefox icons?

from firefox-gnome-theme.

Ah, I see. I never knew it was partially broken. Then sure, I don't see a problem

from firefox-gnome-theme.

This seems to give a lot of icons a dark color :/

from firefox-gnome-theme.

:/ Screenshot?

from firefox-gnome-theme.

:/

from firefox-gnome-theme.

Are you using system-icons.css or default?

from firefox-gnome-theme.

Default although my customChrome.css has

@import "theme/matching-autocomplete-width.css";
@import "theme/hide-single-tab.css";
@import "theme/matching-autocomplete-width.css";
@import "theme/hide-single-tab.css";
@import "theme/matching-autocomplete-width.css";
@import "theme/gnome-icons.css"

(Duplication caused by the script, should probably fix that unless we tell users to update the git from the profile dir instead of using the script all the time)
(Edit : Also had not noticed but the script has other errors if you keep using the script, we should probably just document how to update from the profile directory)

from firefox-gnome-theme.

Adding system-icons.css fixed it.

from firefox-gnome-theme.

Adding system-icons.css fixed it.

No, it should work without it. But anyways now is fixed, a colon was missing xD

from firefox-gnome-theme.

We should add an update script.

from firefox-gnome-theme.

An update script can't really work without duplication.

from firefox-gnome-theme.

Why? It only should run git pull origin master and maybe remove profile cache if needed.

from firefox-gnome-theme.

It will not work for forks, but will make the work for regular users.

from firefox-gnome-theme.

Because the update script itself can't be updated

Let's say, I have a copy in ~/Downloads which I use to update, this update script can never be updated unless we update (with git pull) both the ~/Downloads copy and the profile directory's copy.

from firefox-gnome-theme.

What about creating the gnomish-optional-features.css file?

@import "theme/hide-single-tab.css"; 
@import "theme/matching-autocomplete-width.css";

Then check with grep if @import "gnomish-optional-features.css"; exists in customChrome.css before adding it.

Or check if firefox-gnome-theme exists, en delete it before coping.

from firefox-gnome-theme.