Code Monkey home page Code Monkey logo

Comments (3)

vladmoroz avatar vladmoroz commented on May 27, 2024 1

I think you are just missing align-items: center on the parent. Ghost buttons mostly behave like plain text in layout, which is what you are seeing; changing variants between light and dark mode is unusual and not something we optimise for.

Your request does make sense in many situations, which we’ll keep tracking this under #434

from themes.

vladmoroz avatar vladmoroz commented on May 27, 2024

Do you have a reference design where this looks weird, or is it just something you noticed?

This is mostly by design because these are optimised to work well with one another and among links (e.g. in a site header).

Otherwise with reasonable spacing between ghost buttons, the backgrounds would overlap each other on hover, which feels weird.

from themes.

aryankarim avatar aryankarim commented on May 27, 2024

Sure! Here is a GIF.

2024-04-20-18-45-29_HKK7GbMN-ezgif com-video-to-gif-converter

These are buttons with variant="outline" when I change it to ghost, the whole layout is affected. While the parent div has these innocent tailwind classes "flex justify-center gap-2 p-1"

<Button variant={isDark ? "outline" : "ghost"}>
   <NavLink href={item.path as string}>{item.name}</NavLink>
</Button>

I could just solve the issue with className={isDark ? "" : "px-4 py-2"}, but IMO this is better addressed on the framework.

from themes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.