Comments (3)
I think you are just missing align-items: center
on the parent. Ghost buttons mostly behave like plain text in layout, which is what you are seeing; changing variants between light and dark mode is unusual and not something we optimise for.
Your request does make sense in many situations, which we’ll keep tracking this under #434
from themes.
Do you have a reference design where this looks weird, or is it just something you noticed?
This is mostly by design because these are optimised to work well with one another and among links (e.g. in a site header).
Otherwise with reasonable spacing between ghost buttons, the backgrounds would overlap each other on hover, which feels weird.
from themes.
Sure! Here is a GIF.
These are buttons with variant="outline"
when I change it to ghost
, the whole layout is affected. While the parent div has these innocent tailwind classes "flex justify-center gap-2 p-1"
<Button variant={isDark ? "outline" : "ghost"}>
<NavLink href={item.path as string}>{item.name}</NavLink>
</Button>
I could just solve the issue with className={isDark ? "" : "px-4 py-2"}
, but IMO this is better addressed on the framework.
from themes.
Related Issues (20)
- TextField autofocus HOT 1
- [Feature Request] Accordion
- Cannot find module `@radix-ui\themes\dist\cjs` HOT 2
- [Switch] Issue- Screen readers announce "Button" instead of "Switch". HOT 1
- [Tooltip] Issue: Text inside is based on theme HOT 1
- Button vanishes after adding type HOT 1
- [Dialog] Issue
- [Avatar] Conditionally set color HOT 3
- [Question] Why separate layout, margin and another props? HOT 1
- [DropdownMenu] Issue- Dropdown can't be navigated with TAB key HOT 2
- Left align Radio Card HOT 1
- Select Trigger Color Prop Broken HOT 1
- Improve documentation on customizing the CSS variables (e.g. the Container max widths) HOT 1
- [SegmentedControl] Disabled items not supported HOT 1
- [Question] accordions expanding with code HOT 1
- [Alert Dialog] - dialog has no close button
- Dialog in Dropdown Menu: Space Bar Not Working in Inputs HOT 5
- [RadioCards] Issue with import RadioCard HOT 1
- How do I trigger a Dialog from an outside component?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from themes.