Code Monkey home page Code Monkey logo

Comments (11)

odeyal0 avatar odeyal0 commented on May 29, 2024 1

Need to check.

from primitives.

odeyal0 avatar odeyal0 commented on May 29, 2024 1

I won't create issue "context menu + modal dialog bug" because it was fixed by updating @radix-ui/react-dialog from 1.0.4 to 1.0.5 in my project)

from primitives.

benoitgrelard avatar benoitgrelard commented on May 29, 2024

What is the issue here? I don't see anything wrong when I open the sandbox. Can you please be more descriptive?

from primitives.

odeyal0 avatar odeyal0 commented on May 29, 2024

The context menu item is selected by right click, which should not happen.
In this example, the problem does not appear to be critical. But in my real application, when I select a context menu item, a radix modal window opens. The modal window also uses the portal. A bug occurs, after which the context menu cannot be opened.

I tried to make a minimal example, because looks like the problem is in the right-click selection.
If necessary, I can make an example with a modal window.

from primitives.

benoitgrelard avatar benoitgrelard commented on May 29, 2024

I still don't see what you mean in the video or when I try with the sandbox.

The context menu item is selected by right click, which should not happen.

What do you mean here?

from primitives.

odeyal0 avatar odeyal0 commented on May 29, 2024

Function "onSelect" should be called only on left mouse click, but in the video it's called on right mouse click. (see top left corner, and console on the video)

from primitives.

benoitgrelard avatar benoitgrelard commented on May 29, 2024

Yeah I see, I can't seem to reproduce it using your sandbox though…

from primitives.

odeyal0 avatar odeyal0 commented on May 29, 2024

You need to quickly right-click and move the mouse to the right and down.

from primitives.

benoitgrelard avatar benoitgrelard commented on May 29, 2024

I see, the speed doesn't matter though.

What you are doing is what I do here in the video but just super fast, so it feels like a bug but isn't really one:

  • right-click but keep holding (pointerdown)
  • move cursor over an item (pointermove)
  • release cursor (pointerup)
CleanShot.2024-03-05.at.18.28.18.mp4

I can do exactly the same thing with the native menu going fast too.

from primitives.

odeyal0 avatar odeyal0 commented on May 29, 2024

Yes it is.
Then it's probably worth closing the issue. I’ll create a new issue for a context menu with modal window bug later.

from primitives.

benoitgrelard avatar benoitgrelard commented on May 29, 2024

It would be the same thing though right?

from primitives.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.