Code Monkey home page Code Monkey logo

Comments (4)

benoitgrelard avatar benoitgrelard commented on September 26, 2024 1

And fixing it too! ♥️

from primitives.

nicholaschiang avatar nicholaschiang commented on September 26, 2024 1

One thing I want to flag here: It seems like hover: interactions with elements covered by a popover with visibility: hidden are still not triggered until the popover is closed. Clicking where the popover is registers as a click outside and closes the popover, allowing interaction with the elements underneath. I suspect pointer-events: none is needed to allow interactions with elements underneath the hidden popover.

Screen.Recording.2024-02-29.at.12.45.49.PM.mov

from primitives.

benoitgrelard avatar benoitgrelard commented on September 26, 2024 1

Yes that's a great point, if the intention is for it to behave as if it was already closed, then adding pointer-events: none might make sense too. Would you mind opening another PR with that change?

from primitives.

benoitgrelard avatar benoitgrelard commented on September 26, 2024

You are 100% correct! That is an oversight from our part, thanks for raising an issue!

from primitives.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.