Issues with our type definitions about primitives HOT 8 CLOSED

@chaance @jjenzz just pinging here for now before assigning anyone.

from primitives.

Also not sure if it's related or not, but trying to build a single package gives me this:

from primitives.

Also not sure if it's related or not, but trying to build a single package gives me this:

Have you tried yarn workspace @interop-ui/react-dialog build from root?

from primitives.

Also not sure if it's related or not, but trying to build a single package gives me this:

Have you tried yarn workspace @interop-ui/react-dialog build from root?

Same error exactly when doing this from root.

from primitives.

I guess it makes sense, because utils hasn't been built yet. That's why we need the whole topological order thing right?

from primitives.

Ok a bit more on this:

• I did a new build locally
• still getting the old parts in styles.
• I then deleted my local .parcel-cache folder
• I ran another build
• now the parts are correct in styles

🤔 That's kinda worrying I guess, it means something was using the cache rather than latest stuff.
@jjenzz I seem to remember there was some discussion around caching in parcel, do you remember if that was related?

That's one of the issues potentially resolved (although I'm not sure that's a real solution).
I'm still trying to figure out how to deal with the other one.

from primitives.

That's interesting. I ran yarn workspace @interop-ui/react-dialog build locally and it worked hence the suggestion so I wonder how my parcel-cache wasn't in a tizzy and yours was 🤔 definitely not good. Perhaps we should suffix our publish build script with --no-cache for now.

What's the remaining issue? The types? I wonder if the polymorphic stuff I was doing would help with all this 😬

As a quick test, we could try deleting the DialogStaticProps stuff and doing the Object.assign thing instead. That will reduce one layer of complexity in our types and might help reveal something 🤷‍♀️

from primitives.

That's interesting. I ran yarn workspace @interop-ui/react-dialog build locally and it worked hence the suggestion so I wonder how my parcel-cache wasn't in a tizzy and yours was 🤔 definitely not good. Perhaps we should suffix our publish build script with --no-cache for now.

Well, that's still wrong right? It worked for you probably because you had done a full build at some point and had the @interop-ui/utils package build in its dist. So when building just @interop-ui/react-dialog, it did find @interop-ui/utils/dist/index.js. If you clean your cache before you'll see you'll get the same error.

What's the remaining issue? The types? I wonder if the polymorphic stuff I was doing would help with all this 😬
As a quick test, we could try deleting the DialogStaticProps stuff and doing the Object.assign thing instead. That will reduce one layer of complexity in our types and might help reveal something 🤷‍♀️

I don't think it has anything to do with this.
If you look at that screenshot I posted in the original issue:

See the import("react/utils/src").ForwardRefExoticComponentWithAs part?

It's more as if it's not resolving properly when building the type definitions.
Perhaps something to do with the monorepo?
I don't know if that import() thing should work, but regardless it definitely shouldn't be pointing to src right?

from primitives.