Code Monkey home page Code Monkey logo

Comments (5)

raddad772 avatar raddad772 commented on May 12, 2024 1

Yeah, the Undocumented Z80 says IN is different from OUT,but I have the same code used. I need to investigate this a bit deeply.
As a side-note, I'm glad the tests need this level of examination to have an issue. We will end up with super powerful tests!

from jsmoo.

raddad772 avatar raddad772 commented on May 12, 2024

Hm. My core passes zexall, but I don't actually know if that tests OUTI. I'll look into it, thanks
Do be aware of https://zxe.io/depot/documents/Undocumented%20Z80%20Flags%20rev1.0%20%282018-08-21%29%28Banks,%20David%29%28en%29%5B%21%5D.pdf please, but I don't see C modified by OUTI or OTIR there. So I'll check into it

from jsmoo.

raddad772 avatar raddad772 commented on May 12, 2024

So, The Undocumented Z80 Documented, says

And now the for OUTI/OTIR/OUTD/OTDR instructions. Take state of the L after the increment
or decrement of HL; add the value written to the I/O port to; call that k for now. If k > 255,
then the CF and HF flags are set

Furthermore, I asked other emulator authors, and they replied that they implemented it this way too.

Thanks for the Issues. Keep them coming, I'd rather some false positives than let through any bad tests!

from jsmoo.

friol avatar friol commented on May 12, 2024

I've adapted the flag behaviour to what The Undocumented Z80 says (and corrected C and H flags), but I still think the flags for 0xEDB3 are wrong in the tests. I have the same code for 0xEDA3 (OUTI), and 0xEDA3 passes all the tests.
Thanks.

from jsmoo.

raddad772 avatar raddad772 commented on May 12, 2024

The current behavior is definitely the most correct understood behavior now, this should be resolved

from jsmoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.