Comments (5)
Yeah, the Undocumented Z80 says IN is different from OUT,but I have the same code used. I need to investigate this a bit deeply.
As a side-note, I'm glad the tests need this level of examination to have an issue. We will end up with super powerful tests!
from jsmoo.
Hm. My core passes zexall, but I don't actually know if that tests OUTI. I'll look into it, thanks
Do be aware of https://zxe.io/depot/documents/Undocumented%20Z80%20Flags%20rev1.0%20%282018-08-21%29%28Banks,%20David%29%28en%29%5B%21%5D.pdf please, but I don't see C modified by OUTI or OTIR there. So I'll check into it
from jsmoo.
So, The Undocumented Z80 Documented, says
And now the for OUTI/OTIR/OUTD/OTDR instructions. Take state of the L after the increment
or decrement of HL; add the value written to the I/O port to; call that k for now. If k > 255,
then the CF and HF flags are set
Furthermore, I asked other emulator authors, and they replied that they implemented it this way too.
Thanks for the Issues. Keep them coming, I'd rather some false positives than let through any bad tests!
from jsmoo.
I've adapted the flag behaviour to what The Undocumented Z80 says (and corrected C and H flags), but I still think the flags for 0xEDB3 are wrong in the tests. I have the same code for 0xEDA3 (OUTI), and 0xEDA3 passes all the tests.
Thanks.
from jsmoo.
The current behavior is definitely the most correct understood behavior now, this should be resolved
from jsmoo.
Related Issues (20)
- NES only MMC3 implemented
- Z80 t-state pin accuracy is...low
- ZX Spectrum no way to load a tape, etc. HOT 1
- SPC700 tests never start with H-flag set HOT 5
- sm83: Possible errors in tests HOT 3
- topic addition for better community reach HOT 1
- Tests for opcode 0xdb (Z80) are not reproducible HOT 1
- Query - How to know when test ends? HOT 1
- Z80 - Wrong values of A for opcode tests ED 5F HOT 3
- What is FD 18 testing? HOT 1
- Z80 opcodes with 11 cycles instead of 12 HOT 2
- Are the flags potentially incorrect for FD 18?
- HALT instruction (0x76) increments PC HOT 4
- Z80 100/101 tests don't reflect what your generated opcodes does HOT 1
- Z80 needs test cases for `ed bx` opcodes when instruction would not jump
- Z80: flag `C` for `INI` instruction (EDA2) does not seem to be correct HOT 1
- SPC700 SUBW tests do not test 0, 0
- sm83 tests: IME/IE/EI confusion
- Apple IIgs support?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsmoo.