Code Monkey home page Code Monkey logo

Comments (3)

radar avatar radar commented on September 15, 2024

At @cultureamp we were already using HTTPotion in one of our applications which uses Elastic as a dependency. It made sense to me to only have one HTTP library as a dependency, and so that's what I chose. It's also the one I'm more familiar with.

whether we should consider passing ibrowse options into Potion requests
... for more optimal results.

What would this allow people to do? What options in particular are you thinking about here? What do you mean by "optimal results"?

from elastic.

radar avatar radar commented on September 15, 2024

After actually reading the article, now it makes more sense. I think that Elastic would allow you to pass through these options already, given that the options passed to Elastic.HTTP.post are passed directly to HTTPoison anyway.

For functions that call HTTP functions, I don't know if it would even be possible to pass in ibrowse options from there.

I'm fine with leaving the dependency as HTTPotion for now.

from elastic.

bglusman avatar bglusman commented on September 15, 2024

@radar sorry, been meaning to follow up on this... I guess I'd think you'd want to customize it once at the config layer and then always use those settings instead of defaults for all requests? We havent shipped our app using this to production yet and it will probably be fine with whatever settings, but it's definitely possible to pass in ibrowse options from a few places, but I think it HTTPotion is the library we're using it needs to fit into the abstractions... or maybe we can abstract it so it works with either HTTPotion or HTTPoison since the interfaces are very similar? Dunno... can take a crack at if I have time, but I'm not using raw HTTP anywhere, but relying on search and raw_search in a few places, and agree I wouldn't want to specify options there, but thing I should be able to configure options that, if present, get passed in.

from elastic.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.